Closed
Bug 1261405
Opened 8 years ago
Closed 8 years ago
PushPermissionDescriptor in Permissions.webidl is wrong ('userVisible' should be 'userVisibleOnly')
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: marco, Assigned: lina)
References
Details
(Keywords: dev-doc-needed, site-compat, Whiteboard: btpp-active)
Attachments
(1 file)
5.35 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
From https://w3c.github.io/permissions/#push, it should be: dictionary PushPermissionDescriptor : PermissionDescriptor { boolean userVisibleOnly = false; }; In http://mxr.mozilla.org/mozilla-central/source/dom/webidl/Permissions.webidl, it is: dictionary PushPermissionDescriptor : PermissionDescriptor { boolean userVisible = false; };
Comment 1•8 years ago
|
||
Kit, can you look at this? Thanks.
Blocks: 1105827
Flags: needinfo?(kcambridge)
Assignee | ||
Comment 2•8 years ago
|
||
Looks like it was renamed in https://github.com/w3c/push-api/pull/138. We just didn't update it because we use a quota system instead of `userVisible{Only}`. Seems like a small change; I'll just take care of it now.
Assignee: nobody → kcambridge
Status: NEW → ASSIGNED
Flags: needinfo?(kcambridge)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8739196 -
Flags: review?(amarchesini)
Updated•8 years ago
|
Attachment #8739196 -
Flags: review?(amarchesini) → review+
Updated•8 years ago
|
Whiteboard: btpp-active
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b5dbf1464c4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Reporter | ||
Comment 6•8 years ago
|
||
https://simple-push-demo.appspot.com/ is now failing because it was using `userVisibleOnly` and we're now throwing a NS_ERROR_NOT_IMPLEMENTED exception (see bug 1250902).
Comment 7•8 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/permissions-query-s-uservisible-option-has-been-renamed-to-uservisibleonly/
Keywords: site-compat
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•