PushPermissionDescriptor in Permissions.webidl is wrong ('userVisible' should be 'userVisibleOnly')

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: marco, Assigned: lina)

Tracking

({dev-doc-needed, site-compat})

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

Reporter

Description

3 years ago
From https://w3c.github.io/permissions/#push, it should be:
dictionary PushPermissionDescriptor : PermissionDescriptor {
  boolean userVisibleOnly = false;
};

In http://mxr.mozilla.org/mozilla-central/source/dom/webidl/Permissions.webidl, it is:
dictionary PushPermissionDescriptor : PermissionDescriptor {
  boolean userVisible = false;
};
Kit, can you look at this? Thanks.
Blocks: 1105827
Flags: needinfo?(kcambridge)
Looks like it was renamed in https://github.com/w3c/push-api/pull/138. We just didn't update it because we use a quota system instead of `userVisible{Only}`. Seems like a small change; I'll just take care of it now.
Assignee: nobody → kcambridge
Status: NEW → ASSIGNED
Flags: needinfo?(kcambridge)
Attachment #8739196 - Flags: review?(amarchesini)
Attachment #8739196 - Flags: review?(amarchesini) → review+
Whiteboard: btpp-active

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3b5dbf1464c4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Reporter

Comment 6

3 years ago
https://simple-push-demo.appspot.com/ is now failing because it was using `userVisibleOnly` and we're now throwing a NS_ERROR_NOT_IMPLEMENTED exception (see bug 1250902).
Assignee

Updated

3 years ago
Blocks: 1266821
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.