1261405 - PushPermissionDescriptor in Permissions.webidl is wrong ('userVisible' should be 'userVisibleOnly')

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marco Castelluccio [:marco]]

From https://w3c.github.io/permissions/#push, it should be:
dictionary PushPermissionDescriptor : PermissionDescriptor {
  boolean userVisibleOnly = false;
};

In http://mxr.mozilla.org/mozilla-central/source/dom/webidl/Permissions.webidl, it is:
dictionary PushPermissionDescriptor : PermissionDescriptor {
  boolean userVisible = false;
};

Comment 1

[Andrew McCreight [:mccr8]]

Kit, can you look at this? Thanks.

Comment 2

[Lina Butler [:lina]]

Looks like it was renamed in https://github.com/w3c/push-api/pull/138. We just didn't update it because we use a quota system instead of `userVisible{Only}`. Seems like a small change; I'll just take care of it now.

Comment 3

[Lina Butler [:lina]]

Attachment: userVisibleOnly.patch

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b5dbf1464c4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b5dbf1464c4

Comment 6

[Marco Castelluccio [:marco]]

https://simple-push-demo.appspot.com/ is now failing because it was using `userVisibleOnly` and we're now throwing a NS_ERROR_NOT_IMPLEMENTED exception (see bug 1250902).

Comment 7

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/permissions-query-s-uservisible-option-has-been-renamed-to-uservisibleonly/