Closed
Bug 1261424
Opened 9 years ago
Closed 9 years ago
Adding a class for the pin job locator
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rbillings, Assigned: jfrench)
References
()
Details
Attachments
(1 file)
Test automation for pinning a job has to use a very fragile locator when using the pin icon* due to the current page structure.
Can you add a class to the "a" element?
(By.CSS_SELECTOR, '#job-details-actionbar .nav .nav li:nth-child(1) a')
|
Assignee | |
Comment 1•9 years ago
|
||
Cool, I think we can add an id for this one since it's unique. I'll add a couple of other ids and classes elsewhere that could be useful at the same time.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8750961 [details] [review]
[treeherder] tojon:add-button-ids > mozilla:master
PR for review at your leisure :)
Attachment #8750961 -
Flags: review?(wlachance)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8750961 [details] [review]
[treeherder] tojon:add-button-ids > mozilla:master
Looks good, ty!
Attachment #8750961 -
Flags: review?(wlachance) → review+
|
|
||
Comment 5•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla/treeherder/commit/98ada83725e8de6847cf419d81e202918a099d54
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 7•9 years ago
|
||
Thanks for taking care of this!
You need to log in
before you can comment on or make changes to this bug.
Description
•