1261428 - Replace an additional JS_ReportError

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Now that we have infrastructure for this!

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8737294 [details] [diff] [review]
Patch

r=me with a better commit message.

That said, I looked at the use of aCx here, and it's shenanigans all the way.  The only remaining consumer is the nsJSUtils::GetCallingLocation call when !newInfo->mTimeoutString.IsEmpty().  But if you look at the callers, the _Function_ overload of WorkerGlobalScope::SetInterval is what passes the caller JSContext (this is the case when it does not get used) while the string version passes GetCurrentThreadJSContext() for some bizarre reason.  Same thing for WorkerGlobalScope::SetTimeout.  Mind fixing that stuff to just pass through the JSContext without shenanigans?

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e574b87617b

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67f70018cbb5

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e574b87617b
https://hg.mozilla.org/mozilla-central/rev/67f70018cbb5