Closed
Bug 1261438
Opened 9 years ago
Closed 9 years ago
Android package names went from *android-arm* to *androideabi-arm* again
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(2 files)
A lot like bug 1257648, starting with https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e8c2eecfac918a8e0c0e8f9e0bb396d7d1502948
My quess for now is bug 1260622, but I haven't dug into it yet.
Comment 1•9 years ago
|
||
sebastian: this will explain your artifact failures this morning, I bet.
Flags: needinfo?(s.kaspari)
Comment 2•9 years ago
|
||
Same manifestation as Bug 1257648. chanchester, any chance we could start running AB for Fennec as well? It should Just Work the same.
Flags: needinfo?(cmanchester)
Assignee | ||
Comment 3•9 years ago
|
||
glandium, can this be reverted, or do we need to adapt?
Nick, I think we need to go further, to smoke testing the resulting build, for AB to detect this reasonably quickly.
Flags: needinfo?(cmanchester)
Comment 5•9 years ago
|
||
If the target triple is noisy, let's just accept -arm and -i386
instead of being strict. We can be more strict when things have
settled.
Review commit: https://reviewboard.mozilla.org/r/43937/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43937/
Attachment #8737374 -
Flags: review?(cmanchester)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8737374 [details]
MozReview Request: Bug 1261438 - Generalize Android artifact package names. r?chmanchester
https://reviewboard.mozilla.org/r/43937/#review40545
r+ because this patch seems very unlikely to do harm. But we should actually fix the package name or figure out what else might be broken here.
Attachment #8737374 -
Flags: review?(cmanchester) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d50240348923d829500a0284d832599804987e5c
Bug 1261438 - Generalize Android artifact package names. r=chmanchester
Comment 9•9 years ago
|
||
bugherder |
Comment 10•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #1)
> sebastian: this will explain your artifact failures this morning, I bet.
Ah. Thank you for flagging me. Everything's working again. :)
Flags: needinfo?(s.kaspari)
Comment 11•9 years ago
|
||
This is also affecting other tools that hardcode the platform name. E.g. nightly.mozilla.org is broken because the link points to the old nightly before bug 1261438 landed.
Comment 12•9 years ago
|
||
(In reply to Jim Chen [:jchen] [:darchons] from comment #11)
> before bug 1261438 landed.
Before bug *1260622* landed
Assignee | ||
Comment 13•9 years ago
|
||
We discussed this Friday on irc, we can normalize the package name in package-name.mk (we already do so for other platforms).
Patch on try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e518f23629b2
Flags: needinfo?(mh+mozilla)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → cmanchester
Assignee | ||
Comment 14•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44169/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44169/
Attachment #8737901 -
Flags: review?(nalexander)
Comment 15•9 years ago
|
||
Comment on attachment 8737901 [details]
MozReview Request: Bug 1261438 - Normalize "TARGET_OS" to "android" in package-name.mk for android builds. r=nalexander
https://reviewboard.mozilla.org/r/44169/#review40797
Looking at http://archive.mozilla.org/pub/mobile/releases/45.0/android-x86/en-US/ and http://archive.mozilla.org/pub/mobile/releases/45.0/android-api-11/en-US/ the names are like "android-{arm,x86}", so this seems good.
Attachment #8737901 -
Flags: review?(nalexander) → review+
Comment 16•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Comment 17•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•