Closed Bug 1261438 Opened 4 years ago Closed 4 years ago

Android package names went from *android-arm* to *androideabi-arm* again

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(2 files)

sebastian: this will explain your artifact failures this morning, I bet.
Flags: needinfo?(s.kaspari)
Same manifestation as Bug 1257648.  chanchester, any chance we could start running AB for Fennec as well?  It should Just Work the same.
Flags: needinfo?(cmanchester)
glandium, can this be reverted, or do we need to adapt?

Nick, I think we need to go further, to smoke testing the resulting build, for AB to detect this reasonably quickly.
Flags: needinfo?(cmanchester)
Meant to ni? in comment 3.
Flags: needinfo?(mh+mozilla)
If the target triple is noisy, let's just accept -arm and -i386
instead of being strict.  We can be more strict when things have
settled.

Review commit: https://reviewboard.mozilla.org/r/43937/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43937/
Attachment #8737374 - Flags: review?(cmanchester)
Comment on attachment 8737374 [details]
MozReview Request: Bug 1261438 - Generalize Android artifact package names. r?chmanchester

https://reviewboard.mozilla.org/r/43937/#review40545

r+ because this patch seems very unlikely to do harm. But we should actually fix the package name or figure out what else might be broken here.
Attachment #8737374 - Flags: review?(cmanchester) → review+
Leaving this open to track fixing this for real.
Keywords: leave-open
(In reply to Nick Alexander :nalexander from comment #1)
> sebastian: this will explain your artifact failures this morning, I bet.

Ah. Thank you for flagging me. Everything's working again. :)
Flags: needinfo?(s.kaspari)
This is also affecting other tools that hardcode the platform name. E.g. nightly.mozilla.org is broken because the link points to the old nightly before bug 1261438 landed.
(In reply to Jim Chen [:jchen] [:darchons] from comment #11)
> before bug 1261438 landed.

Before bug *1260622* landed
We discussed this Friday on irc, we can normalize the package name in package-name.mk (we already do so for other platforms).

Patch on try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e518f23629b2
Flags: needinfo?(mh+mozilla)
Assignee: nobody → cmanchester
Comment on attachment 8737901 [details]
MozReview Request: Bug 1261438 - Normalize "TARGET_OS" to "android" in package-name.mk for android builds. r=nalexander

https://reviewboard.mozilla.org/r/44169/#review40797

Looking at http://archive.mozilla.org/pub/mobile/releases/45.0/android-x86/en-US/ and http://archive.mozilla.org/pub/mobile/releases/45.0/android-api-11/en-US/ the names are like "android-{arm,x86}", so this seems good.
Attachment #8737901 - Flags: review?(nalexander) → review+
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/3c8b8dfae942
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.