Created attachment 8737304 [details] [diff] [review] patch calling Role() for every inserted/created accessible is not something we should do
Attachment #8737304 - Flags: review?(mzehe)
Comment on attachment 8737304 [details] [diff] [review] patch r=me, this looks like a great optimization. But the following nit is definitely something I'd like to see fixed: >diff --git a/accessible/base/TextRange.cpp b/accessible/base/TextRange.cpp >- if (nsAccUtils::IsEmbeddedObject(next)) >+ if (!next->IsText()) > aChildren->AppendElement(next); You set all the other checks in this file in braces, please do it with this one, too, for consistency. It just feels wrong to leave this one out. ;) Thanks!
Attachment #8737304 - Flags: review?(mzehe) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0c6dd45e0cfcb641746485511767fea770e8459 Bug 1261439 - replace nsAccUtils::IsEmbeddedObject on a bit flag check, r=marcoz
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
2 years ago
Assignee: nobody → surkov.alexander
You need to log in before you can comment on or make changes to this bug.