1261439 - replace nsAccUtils::IsEmbeddedObject on a bit flag check

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

calling Role() for every inserted/created accessible is not something we should do

Comment 1

[Marco Zehe (:MarcoZ)]

Comment on attachment 8737304 [details] [diff] [review]
patch

r=me, this looks like a great optimization. But the following nit is definitely something I'd like to see fixed:

>diff --git a/accessible/base/TextRange.cpp b/accessible/base/TextRange.cpp
>-      if (nsAccUtils::IsEmbeddedObject(next))
>+      if (!next->IsText())
>         aChildren->AppendElement(next);
You set all the other checks in this file in braces, please do it with this one, too, for consistency. It just feels wrong to leave this one out. ;) Thanks!

Comment 2

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0c6dd45e0cfcb641746485511767fea770e8459
Bug 1261439 - replace nsAccUtils::IsEmbeddedObject on a bit flag check, r=marcoz

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0c6dd45e0cf