replace nsAccUtils::IsEmbeddedObject on a bit flag check

RESOLVED FIXED in Firefox 48

Status

()

Product:
Core
Component:
Disability Access APIs
Type:
defect
Status:
RESOLVED FIXED
Opened:
3 years ago
Updated:
3 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

Version:
unspecified
Target:
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

patch
16.03 KB, patch
MarcoZ
: review+
Details | Diff | Splinter Review
Posted patch patch — — Splinter Review 
calling Role() for every inserted/created accessible is not something we should do
Attachment #8737304 - Flags: review?(mzehe)
Comment on attachment 8737304 [details] [diff] [review]
patch

r=me, this looks like a great optimization. But the following nit is definitely something I'd like to see fixed:

>diff --git a/accessible/base/TextRange.cpp b/accessible/base/TextRange.cpp
>-      if (nsAccUtils::IsEmbeddedObject(next))
>+      if (!next->IsText())
>         aChildren->AppendElement(next);
You set all the other checks in this file in braces, please do it with this one, too, for consistency. It just feels wrong to leave this one out. ;) Thanks!
Attachment #8737304 - Flags: review?(mzehe) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0c6dd45e0cfcb641746485511767fea770e8459
Bug 1261439 - replace nsAccUtils::IsEmbeddedObject on a bit flag check, r=marcoz
https://hg.mozilla.org/mozilla-central/rev/d0c6dd45e0cf
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee: nobody → surkov.alexander
You need to log in before you can comment on or make changes to this bug.