Closed
Bug 1261452
Opened 8 years ago
Closed 8 years ago
do_AddRef shouldn't require an rvalue-reference
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
2.68 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Per discussion on IRC. I'll write a patch.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8737453 -
Flags: review?(nfroyd)
Comment 2•8 years ago
|
||
Comment on attachment 8737453 [details] [diff] [review] do_AddRef shouldn't require an rvalue-reference. v1 Review of attachment 8737453 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the fixing the bits in nsCSSFrameConstructor.cpp. Would you fix the one in gfx/src/nsDeviceContext.cpp, too, please? http://mxr.mozilla.org/mozilla-central/source/gfx/src/nsDeviceContext.cpp#147 r=me with that change.
Attachment #8737453 -
Flags: review?(nfroyd) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4678a49486b3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•