Closed Bug 1261452 Opened 4 years ago Closed 4 years ago

do_AddRef shouldn't require an rvalue-reference

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Per discussion on IRC. I'll write a patch.
Comment on attachment 8737453 [details] [diff] [review]
do_AddRef shouldn't require an rvalue-reference. v1

Review of attachment 8737453 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fixing the bits in nsCSSFrameConstructor.cpp.  Would you fix the one in gfx/src/nsDeviceContext.cpp, too, please?

http://mxr.mozilla.org/mozilla-central/source/gfx/src/nsDeviceContext.cpp#147

r=me with that change.
Attachment #8737453 - Flags: review?(nfroyd) → review+
Blocks: 1261552
https://hg.mozilla.org/mozilla-central/rev/4678a49486b3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.