1261477 - Values of long watch expressions are not visible

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160330030326
STR:
1. Open attachment 8724506 [details], set breakpoint at line 3, click on the page
2. Add watch expression:  "window || window || window || window || window || window || window"
3. Resize sidebar to be as narrow as possible

AR:  Value of long watch expression isn't visible
ER:  Values of watch expressions should be visible

Note:  You can accidentally run into bug 1211514

Comment 1

[arni2033]

Screenshot:
> https://dl.dropboxusercontent.com/s/jaumw9ios8v60ep/bug%201261477%20comment%201.png?dl=0

Comment 2

[Eddy Bruel [:ejpbruel]]

Another UI papercut. Assigning P3.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Values of long watch expressions are not visible

Since XUL can't do max-width values for percentages, I compromised with using a
fixed max-width. I added a custom class name based on the label's name to the
to the VariableView's Scope view and wrote some CSS to match off of that. This
way only the Watch Expressions will be affected by this new rule, as they seem
to have the ability to grow much wider than the other Scope parameters.

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: watch-expressions.mov

A short video showing the new behavior.

Comment 5

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8743430 [details] [diff] [review]
Values of long watch expressions are not visible

For debugger frontend code, James is a better pick for review.

Comment 6

[James Long (:jlongster)]

Comment on attachment 8743430 [details] [diff] [review]
Values of long watch expressions are not visible

Review of attachment 8743430 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good!

Comment 7

[Greg Tatum [:gregtatum]]

Attachment: Values of long watch expressions are not visible

Updated reviewer in commit message.

Comment 8

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f686628d9d8

Comment 9

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b30bbbf4ef4e

Comment 10

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ff26c81d902

Comment 11

[Greg Tatum [:gregtatum]]

Attachment: Make values of long watch expressions visible

My changes got clobbered on a rebase with the firebug theme additions. When I went
back to fix this I realized that I was basing the class name of the element on
a localized string, which would break the CSS in other languages. This new
approach should fix it. Sorry for the re-review.

Comment 12

[James Long (:jlongster)]

Comment on attachment 8751282 [details] [diff] [review]
Make values of long watch expressions visible

Review of attachment 8751282 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I haven't been watching bugzilla as much while working on the new debugger :(

Comment 13

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e6e0ae085f3

Comment 14

[Greg Tatum [:gregtatum]]

Attachment: Make values of long watch expressions visible

This patch is a rebase.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/757bd4dfc3c3
Make values of long watch expressions visible r=jlongster

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/757bd4dfc3c3