Closed
Bug 1261505
Opened 8 years ago
Closed 8 years ago
Use consistent syntax for prototype methods
Categories
(DevTools :: Shared Components, defect)
DevTools
Shared Components
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
1.15 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
All the other methods use the style { myMethod() { ... } } while these two methods use { myMethod: function () { ... } } For consistency, we should use the common style here.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8737379 -
Flags: review?(jsantell)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f4043d9caf5
Updated•8 years ago
|
Attachment #8737379 -
Flags: review?(jsantell) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/41d126344f3d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•