Closed Bug 1261527 Opened 8 years ago Closed 8 years ago

Follow-up: Combined synced devices into a folder in history

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(19 files, 2 obsolete files)

29.35 KB, image/png
Details
152.38 KB, image/png
Details
62.62 KB, image/png
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
5.11 KB, application/zip
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
234.04 KB, image/png
Details
172.48 KB, image/png
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
58 bytes, text/x-review-board-request
sebastian
: review+
Details
1.22 KB, patch
liuche
: review+
Details | Diff | Splinter Review
Instead of having the synced devices all displayed in history, we want to group them in a single folder called "Synced devices". This may be done with expandable items, or with folder-hierarchy style.
Blocks: 1261528
Attached image spec_devicefolder.png
The indentation here might not bode well for my OCD, but it definitely helps create a separation/relationship between group and individual items.
Assignee: nobody → liuche
No longer depends on: 1220928
Status: NEW → ASSIGNED
Just need the cloud resource for the smart folder!
Flags: needinfo?(alam)
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/1-2/
This is a working combined History/Sync panel with a smartfolder and expandable tabs. I need to handle config changes and polish transitions, and also style the smartfolder correctly.
No longer blocks: home-panels
Attached file icon_syncdevices.zip
Flags: needinfo?(alam)
Review commit: https://reviewboard.mozilla.org/r/48605/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48605/
Attachment #8743626 - Attachment description: MozReview Request: Bug 1261527 - WIP (mostly working) Sync folder + expandable tabs → MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian
Attachment #8744539 - Flags: review?(s.kaspari)
Attachment #8744540 - Flags: review?(s.kaspari)
Attachment #8744541 - Flags: review?(s.kaspari)
Attachment #8743626 - Flags: review?(s.kaspari)
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/2-3/
Attachment #8743626 - Flags: review?(s.kaspari)
Attachment #8744539 - Flags: review?(s.kaspari)
Attachment #8744540 - Flags: review?(s.kaspari)
Attachment #8744541 - Flags: review?(s.kaspari)
Review commit: https://reviewboard.mozilla.org/r/49371/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49371/
Attachment #8744539 - Attachment description: MozReview Request: Bug 1261527 - Add swipe to sync. r=sebastian → MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian
Attachment #8746311 - Flags: review?(s.kaspari)
Attachment #8746312 - Flags: review?(s.kaspari)
Attachment #8746313 - Flags: review?(s.kaspari)
Attachment #8746314 - Flags: review?(s.kaspari)
Attachment #8746315 - Flags: review?(s.kaspari)
Attachment #8743626 - Flags: review?(s.kaspari)
Attachment #8744540 - Flags: review?(s.kaspari)
Attachment #8744541 - Flags: review?(s.kaspari)
Attachment #8744539 - Flags: review?(s.kaspari)
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/3-4/
Comment on attachment 8744540 [details]
MozReview Request: Bug 1261527 - Move code around. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48607/diff/1-2/
Comment on attachment 8744541 [details]
MozReview Request: Bug 1261527 - Add clear history button. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48609/diff/1-2/
Comment on attachment 8744539 [details]
MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48605/diff/1-2/
Attached image Screenshot: History level (obsolete) —
Attached image Screenshot: Clients level (obsolete) —
I still need to update the padding on these items, but just a screenshot of this current set of patches.
Attachment #8743626 - Flags: review?(s.kaspari) → review+
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

https://reviewboard.mozilla.org/r/47951/#review46295

::: mobile/android/base/java/org/mozilla/gecko/home/ClientsAdapter.java:118
(Diff revision 4)
> +    @Override
> +    public int getItemViewType(int position) {
> +        return CombinedHistoryItem.ItemType.itemTypeToViewType(getItemTypeForPosition(position));
> +    }
> +
> +    public void setClients(List<RemoteClient> clients) {

Maybe add @UIThread or ThreadUtils.assertOnUIThread() here because this modifies the adapter data.

::: mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java:121
(Diff revision 4)
>          super.onViewCreated(view, savedInstanceState);
>  
> +        mHistoryAdapter = new CombinedHistoryAdapter();
> +        mClientsAdapter = new ClientsAdapter(getContext());
> +
> +        // TODO: Move RecyclerView boilerplate into method?

I guess at least the animator, decoration and default listener could be moved into the constructor (or an init method) of CombinedHistoryRecyclerView?
Comment on attachment 8744541 [details]
MozReview Request: Bug 1261527 - Add clear history button. r=sebastian

https://reviewboard.mozilla.org/r/48609/#review46299
Attachment #8744541 - Flags: review?(s.kaspari) → review+
Comment on attachment 8744540 [details]
MozReview Request: Bug 1261527 - Move code around. r=sebastian

https://reviewboard.mozilla.org/r/48607/#review46297
Attachment #8744540 - Flags: review?(s.kaspari) → review+
https://reviewboard.mozilla.org/r/47951/#review46295

> I guess at least the animator, decoration and default listener could be moved into the constructor (or an init method) of CombinedHistoryRecyclerView?

True. I'd rather keep the animator and decoration anonymous instead of having creating a reference to them in the class, but I'll move some things into a constructor. Later on, I'll move everything else into an init() method, because yeah, that's a lot of code that is not directly relevant to onViewCreated.
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/4-5/
Comment on attachment 8744540 [details]
MozReview Request: Bug 1261527 - Move code around. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48607/diff/2-3/
Comment on attachment 8744541 [details]
MozReview Request: Bug 1261527 - Add clear history button. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48609/diff/2-3/
Comment on attachment 8744539 [details]
MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48605/diff/2-3/
Comment on attachment 8746311 [details]
MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49371/diff/1-2/
Comment on attachment 8746312 [details]
MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49373/diff/1-2/
Comment on attachment 8746313 [details]
MozReview Request: Bug 1261527 - Update strings. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49375/diff/1-2/
Comment on attachment 8746314 [details]
MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49377/diff/1-2/
Comment on attachment 8746315 [details]
MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49379/diff/1-2/
Attachment #8746317 - Attachment is obsolete: true
Attachment #8746319 - Attachment is obsolete: true
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/5-6/
Comment on attachment 8744540 [details]
MozReview Request: Bug 1261527 - Move code around. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48607/diff/3-4/
Comment on attachment 8744541 [details]
MozReview Request: Bug 1261527 - Add clear history button. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48609/diff/3-4/
Comment on attachment 8744539 [details]
MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48605/diff/3-4/
Comment on attachment 8746311 [details]
MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49371/diff/2-3/
Comment on attachment 8746312 [details]
MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49373/diff/2-3/
Comment on attachment 8746313 [details]
MozReview Request: Bug 1261527 - Update strings. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49375/diff/2-3/
Comment on attachment 8746314 [details]
MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49377/diff/2-3/
Comment on attachment 8746315 [details]
MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49379/diff/2-3/
Comment on attachment 8746824 [details]
MozReview Request: Bug 1261527 - Update textsize and layout. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49575/diff/1-2/
Blocks: 1269027
Comment on attachment 8744539 [details]
MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian

https://reviewboard.mozilla.org/r/48605/#review46679
Attachment #8744539 - Flags: review?(s.kaspari) → review+
Comment on attachment 8746311 [details]
MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian

https://reviewboard.mozilla.org/r/49371/#review46681
Attachment #8746311 - Flags: review?(s.kaspari) → review+
Comment on attachment 8746312 [details]
MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian

https://reviewboard.mozilla.org/r/49373/#review46687

::: mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryItem.java:108
(Diff revision 3)
> -            this.deviceExpanded.setImageResource(client.tabs.isEmpty() ? 0 : R.drawable.home_group_collapsed);
> -
>              final long now = System.currentTimeMillis();
>              this.lastModifiedView.setText(RemoteTabsExpandableListAdapter.getLastSyncedString(context, now, client.lastModified));
> +
> +            final boolean isDesktop = "desktop".equals(client.deviceType);

This sounds like it could be a helpful method of the RemoteClient class.
Attachment #8746312 - Flags: review?(s.kaspari) → review+
Comment on attachment 8746313 [details]
MozReview Request: Bug 1261527 - Update strings. r=sebastian

https://reviewboard.mozilla.org/r/49375/#review46689
Attachment #8746313 - Flags: review?(s.kaspari) → review+
Comment on attachment 8746314 [details]
MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian

https://reviewboard.mozilla.org/r/49377/#review46691
Attachment #8746314 - Flags: review?(s.kaspari) → review+
Attachment #8746315 - Flags: review?(s.kaspari) → review+
Comment on attachment 8746315 [details]
MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian

https://reviewboard.mozilla.org/r/49379/#review46693

::: mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java:525
(Diff revision 3)
> +    public void onDestroy() {
> +        super.onDestroyView();

Is this correct? onDestroy() -> super.onDestroyView()
Comment on attachment 8746824 [details]
MozReview Request: Bug 1261527 - Update textsize and layout. r=sebastian

https://reviewboard.mozilla.org/r/49575/#review46695
Attachment #8746824 - Flags: review?(s.kaspari) → review+
Comment on attachment 8747331 [details]
MozReview Request: Bug 1261527 - Long-press on smartfolder. r=sebastian

https://reviewboard.mozilla.org/r/49839/#review46697
Attachment #8747331 - Flags: review?(s.kaspari) → review+
Comment on attachment 8747382 [details]
MozReview Request: Bug 1261527 - Clean up RecyclerView animations. r=sebastian

https://reviewboard.mozilla.org/r/49873/#review46699
Attachment #8747382 - Flags: review?(s.kaspari) → review+
Barbara, Margaret - I realized that there are two strings that this depends on, "Synced devices" and "%n devices". I could uplift this to 48 by using "Synced tabs" and leaving out "%n devices", or we could ask about breaking string freeze on aurora.
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
Hi Delphine, I realized that we have two strings that we want to uplift with these patches, "Synced devices" and "%n devices". Let me know if we can get approval to break string freeze for them. This bug fixes some crashes and also updates our UI to re-include sync setup for people without accounts (which was removed in bug 1220928 which is on 48).
Flags: needinfo?(bbermes) → needinfo?(lebedel.delphine)
Thanks for reaching out :liuche. Yes, I think in this case is OK, but please try to uplift quickly. thanks!
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(margaret.leibovic)
Was using a tablet and realized I'd only centered the smartfolder image but forgot to scale it. r=trivial
Attachment #8748020 - Flags: review+
Depends on: 1269694
Hi Carsten, I realized that I was probably remiss in landing the last patch in this series after/separate from the main series - can you also merge the "Scale smartfolder icon" patch? I'm sorry, I should have actually filed another bug for that.
Flags: needinfo?(cbook)
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: approval from :delphine for string changes
Flags: needinfo?(cbook)
Attachment #8743626 - Flags: approval-mozilla-aurora?
Comment on attachment 8744539 [details]
MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8744539 - Flags: approval-mozilla-aurora?
Comment on attachment 8744540 [details]
MozReview Request: Bug 1261527 - Move code around. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8744540 - Flags: approval-mozilla-aurora?
Comment on attachment 8744541 [details]
MozReview Request: Bug 1261527 - Add clear history button. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8744541 - Flags: approval-mozilla-aurora?
Comment on attachment 8746311 [details]
MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8746311 - Flags: approval-mozilla-aurora?
Comment on attachment 8746312 [details]
MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8746312 - Flags: approval-mozilla-aurora?
Comment on attachment 8746314 [details]
MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8746314 - Flags: approval-mozilla-aurora?
Comment on attachment 8746315 [details]
MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8746315 - Flags: approval-mozilla-aurora?
Comment on attachment 8746824 [details]
MozReview Request: Bug 1261527 - Update textsize and layout. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8746824 - Flags: approval-mozilla-aurora?
Comment on attachment 8747331 [details]
MozReview Request: Bug 1261527 - Long-press on smartfolder. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8747331 - Flags: approval-mozilla-aurora?
Comment on attachment 8747382 [details]
MozReview Request: Bug 1261527 - Clean up RecyclerView animations. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8747382 - Flags: approval-mozilla-aurora?
Comment on attachment 8748020 [details] [diff] [review]
Patch: Scale smartfolder icon

Approval Request Comment
[Feature/regressing bug #]: Next stage of bug 1220928
[User impact if declined]: New users will not have an entry point to sync from the History panel
[Describe test coverage new/current, TreeHerder]: local, nightly
[Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy
[String/UUID change made/needed]: none in this commit
Attachment #8748020 - Flags: approval-mozilla-aurora?
Blocks: 1269888
Blocks: 1269909
Blocks: 1269949
Blocks: 1270197
No longer blocks: 1269949
Hi Liz, not sure if this slipped through the cracks for aurora uplift requests, but just wanted to make sure it's on the radar. I'd like to get this uplifted sooner rather than later because there are some strings. Let me know if there are any problems, thanks!
Flags: needinfo?(lhenry)
Comment on attachment 8743626 [details]
MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian

Restructuring sync folder organization, many patches. 
Early aurora so this seems ok. 
String changes in one patch, approved by delphine.
Flags: needinfo?(lhenry)
Attachment #8743626 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8744539 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8744540 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8744541 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8746311 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8746312 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8746314 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8746315 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8746824 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8747331 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8747382 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8748020 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1270958
Thanks for the screenshot, me and Ludwig translated it for the Swedish version now
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: see release comments above
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
49+ for release note, added "New users will now have an entry point to sync from the History panel"
(In reply to Marcia Knous [:marcia - use ni] from comment #90)
> 49+ for release note, added "New users will now have an entry point to sync
> from the History panel"

This was uplifted to 48.
Flags: needinfo?(mozillamarcia.knous)
Changing relnote flag based on Comment 91. Sylvestre - should this be added to 48 rel note?
Flags: needinfo?(mozillamarcia.knous) → needinfo?(sledru)
yes
Flags: needinfo?(sledru)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.