Closed
Bug 1261527
Opened 8 years ago
Closed 8 years ago
Follow-up: Combined synced devices into a folder in history
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: liuche, Assigned: liuche)
References
Details
Attachments
(19 files, 2 obsolete files)
29.35 KB,
image/png
|
Details | |
152.38 KB,
image/png
|
Details | |
62.62 KB,
image/png
|
Details | |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
5.11 KB,
application/zip
|
Details | |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
234.04 KB,
image/png
|
Details | |
172.48 KB,
image/png
|
Details | |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
1.22 KB,
patch
|
liuche
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Instead of having the synced devices all displayed in history, we want to group them in a single folder called "Synced devices". This may be done with expandable items, or with folder-hierarchy style.
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
The indentation here might not bode well for my OCD, but it definitely helps create a separation/relationship between group and individual items.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → liuche
Assignee | ||
Updated•8 years ago
|
Blocks: combined-history
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Just need the cloud resource for the smart folder!
Flags: needinfo?(alam)
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/47951/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47951/
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/1-2/
Assignee | ||
Comment 6•8 years ago
|
||
This is a working combined History/Sync panel with a smartfolder and expandable tabs. I need to handle config changes and polish transitions, and also style the smartfolder correctly.
Updated•8 years ago
|
No longer blocks: home-panels
Comment 7•8 years ago
|
||
Flags: needinfo?(alam)
Assignee | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48605/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48605/
Attachment #8743626 -
Attachment description: MozReview Request: Bug 1261527 - WIP (mostly working) Sync folder + expandable tabs → MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian
Attachment #8744539 -
Flags: review?(s.kaspari)
Attachment #8744540 -
Flags: review?(s.kaspari)
Attachment #8744541 -
Flags: review?(s.kaspari)
Attachment #8743626 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48607/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48607/
Assignee | ||
Comment 10•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48609/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48609/
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/2-3/
Assignee | ||
Updated•8 years ago
|
Attachment #8743626 -
Flags: review?(s.kaspari)
Attachment #8744539 -
Flags: review?(s.kaspari)
Attachment #8744540 -
Flags: review?(s.kaspari)
Attachment #8744541 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 12•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49371/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49371/
Attachment #8744539 -
Attachment description: MozReview Request: Bug 1261527 - Add swipe to sync. r=sebastian → MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian
Attachment #8746311 -
Flags: review?(s.kaspari)
Attachment #8746312 -
Flags: review?(s.kaspari)
Attachment #8746313 -
Flags: review?(s.kaspari)
Attachment #8746314 -
Flags: review?(s.kaspari)
Attachment #8746315 -
Flags: review?(s.kaspari)
Attachment #8743626 -
Flags: review?(s.kaspari)
Attachment #8744540 -
Flags: review?(s.kaspari)
Attachment #8744541 -
Flags: review?(s.kaspari)
Attachment #8744539 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 13•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49373/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49373/
Assignee | ||
Comment 14•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49375/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49375/
Assignee | ||
Comment 15•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49377/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49377/
Assignee | ||
Comment 16•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49379/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49379/
Assignee | ||
Comment 17•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/3-4/
Assignee | ||
Comment 18•8 years ago
|
||
Comment on attachment 8744540 [details] MozReview Request: Bug 1261527 - Move code around. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48607/diff/1-2/
Assignee | ||
Comment 19•8 years ago
|
||
Comment on attachment 8744541 [details] MozReview Request: Bug 1261527 - Add clear history button. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48609/diff/1-2/
Assignee | ||
Comment 20•8 years ago
|
||
Comment on attachment 8744539 [details] MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48605/diff/1-2/
Assignee | ||
Comment 21•8 years ago
|
||
Assignee | ||
Comment 22•8 years ago
|
||
I still need to update the padding on these items, but just a screenshot of this current set of patches.
Updated•8 years ago
|
Attachment #8743626 -
Flags: review?(s.kaspari) → review+
Comment 23•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian https://reviewboard.mozilla.org/r/47951/#review46295 ::: mobile/android/base/java/org/mozilla/gecko/home/ClientsAdapter.java:118 (Diff revision 4) > + @Override > + public int getItemViewType(int position) { > + return CombinedHistoryItem.ItemType.itemTypeToViewType(getItemTypeForPosition(position)); > + } > + > + public void setClients(List<RemoteClient> clients) { Maybe add @UIThread or ThreadUtils.assertOnUIThread() here because this modifies the adapter data. ::: mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java:121 (Diff revision 4) > super.onViewCreated(view, savedInstanceState); > > + mHistoryAdapter = new CombinedHistoryAdapter(); > + mClientsAdapter = new ClientsAdapter(getContext()); > + > + // TODO: Move RecyclerView boilerplate into method? I guess at least the animator, decoration and default listener could be moved into the constructor (or an init method) of CombinedHistoryRecyclerView?
Comment 24•8 years ago
|
||
Comment on attachment 8744541 [details] MozReview Request: Bug 1261527 - Add clear history button. r=sebastian https://reviewboard.mozilla.org/r/48609/#review46299
Attachment #8744541 -
Flags: review?(s.kaspari) → review+
Comment 25•8 years ago
|
||
Comment on attachment 8744540 [details] MozReview Request: Bug 1261527 - Move code around. r=sebastian https://reviewboard.mozilla.org/r/48607/#review46297
Attachment #8744540 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 26•8 years ago
|
||
https://reviewboard.mozilla.org/r/47951/#review46295 > I guess at least the animator, decoration and default listener could be moved into the constructor (or an init method) of CombinedHistoryRecyclerView? True. I'd rather keep the animator and decoration anonymous instead of having creating a reference to them in the class, but I'll move some things into a constructor. Later on, I'll move everything else into an init() method, because yeah, that's a lot of code that is not directly relevant to onViewCreated.
Assignee | ||
Comment 27•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49575/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49575/
Attachment #8746824 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 28•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/4-5/
Assignee | ||
Comment 29•8 years ago
|
||
Comment on attachment 8744540 [details] MozReview Request: Bug 1261527 - Move code around. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48607/diff/2-3/
Assignee | ||
Comment 30•8 years ago
|
||
Comment on attachment 8744541 [details] MozReview Request: Bug 1261527 - Add clear history button. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48609/diff/2-3/
Assignee | ||
Comment 31•8 years ago
|
||
Comment on attachment 8744539 [details] MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48605/diff/2-3/
Assignee | ||
Comment 32•8 years ago
|
||
Comment on attachment 8746311 [details] MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49371/diff/1-2/
Assignee | ||
Comment 33•8 years ago
|
||
Comment on attachment 8746312 [details] MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49373/diff/1-2/
Assignee | ||
Comment 34•8 years ago
|
||
Comment on attachment 8746313 [details] MozReview Request: Bug 1261527 - Update strings. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49375/diff/1-2/
Assignee | ||
Comment 35•8 years ago
|
||
Comment on attachment 8746314 [details] MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49377/diff/1-2/
Assignee | ||
Comment 36•8 years ago
|
||
Comment on attachment 8746315 [details] MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49379/diff/1-2/
Assignee | ||
Comment 37•8 years ago
|
||
Attachment #8746317 -
Attachment is obsolete: true
Assignee | ||
Comment 38•8 years ago
|
||
Attachment #8746319 -
Attachment is obsolete: true
Assignee | ||
Comment 39•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47951/diff/5-6/
Assignee | ||
Comment 40•8 years ago
|
||
Comment on attachment 8744540 [details] MozReview Request: Bug 1261527 - Move code around. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48607/diff/3-4/
Assignee | ||
Comment 41•8 years ago
|
||
Comment on attachment 8744541 [details] MozReview Request: Bug 1261527 - Add clear history button. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48609/diff/3-4/
Assignee | ||
Comment 42•8 years ago
|
||
Comment on attachment 8744539 [details] MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48605/diff/3-4/
Assignee | ||
Comment 43•8 years ago
|
||
Comment on attachment 8746311 [details] MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49371/diff/2-3/
Assignee | ||
Comment 44•8 years ago
|
||
Comment on attachment 8746312 [details] MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49373/diff/2-3/
Assignee | ||
Comment 45•8 years ago
|
||
Comment on attachment 8746313 [details] MozReview Request: Bug 1261527 - Update strings. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49375/diff/2-3/
Assignee | ||
Comment 46•8 years ago
|
||
Comment on attachment 8746314 [details] MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49377/diff/2-3/
Assignee | ||
Comment 47•8 years ago
|
||
Comment on attachment 8746315 [details] MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49379/diff/2-3/
Assignee | ||
Comment 48•8 years ago
|
||
Comment on attachment 8746824 [details] MozReview Request: Bug 1261527 - Update textsize and layout. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49575/diff/1-2/
Assignee | ||
Comment 50•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49839/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49839/
Attachment #8747331 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 51•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49873/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49873/
Attachment #8747382 -
Flags: review?(s.kaspari)
Comment 52•8 years ago
|
||
Comment on attachment 8744539 [details] MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian https://reviewboard.mozilla.org/r/48605/#review46679
Attachment #8744539 -
Flags: review?(s.kaspari) → review+
Comment 53•8 years ago
|
||
Comment on attachment 8746311 [details] MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian https://reviewboard.mozilla.org/r/49371/#review46681
Attachment #8746311 -
Flags: review?(s.kaspari) → review+
Comment 54•8 years ago
|
||
Comment on attachment 8746312 [details] MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian https://reviewboard.mozilla.org/r/49373/#review46687 ::: mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryItem.java:108 (Diff revision 3) > - this.deviceExpanded.setImageResource(client.tabs.isEmpty() ? 0 : R.drawable.home_group_collapsed); > - > final long now = System.currentTimeMillis(); > this.lastModifiedView.setText(RemoteTabsExpandableListAdapter.getLastSyncedString(context, now, client.lastModified)); > + > + final boolean isDesktop = "desktop".equals(client.deviceType); This sounds like it could be a helpful method of the RemoteClient class.
Attachment #8746312 -
Flags: review?(s.kaspari) → review+
Comment 55•8 years ago
|
||
Comment on attachment 8746313 [details] MozReview Request: Bug 1261527 - Update strings. r=sebastian https://reviewboard.mozilla.org/r/49375/#review46689
Attachment #8746313 -
Flags: review?(s.kaspari) → review+
Comment 56•8 years ago
|
||
Comment on attachment 8746314 [details] MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian https://reviewboard.mozilla.org/r/49377/#review46691
Attachment #8746314 -
Flags: review?(s.kaspari) → review+
Updated•8 years ago
|
Attachment #8746315 -
Flags: review?(s.kaspari) → review+
Comment 57•8 years ago
|
||
Comment on attachment 8746315 [details] MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian https://reviewboard.mozilla.org/r/49379/#review46693 ::: mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java:525 (Diff revision 3) > + public void onDestroy() { > + super.onDestroyView(); Is this correct? onDestroy() -> super.onDestroyView()
Comment 58•8 years ago
|
||
Comment on attachment 8746824 [details] MozReview Request: Bug 1261527 - Update textsize and layout. r=sebastian https://reviewboard.mozilla.org/r/49575/#review46695
Attachment #8746824 -
Flags: review?(s.kaspari) → review+
Comment 59•8 years ago
|
||
Comment on attachment 8747331 [details] MozReview Request: Bug 1261527 - Long-press on smartfolder. r=sebastian https://reviewboard.mozilla.org/r/49839/#review46697
Attachment #8747331 -
Flags: review?(s.kaspari) → review+
Comment 60•8 years ago
|
||
Comment on attachment 8747382 [details] MozReview Request: Bug 1261527 - Clean up RecyclerView animations. r=sebastian https://reviewboard.mozilla.org/r/49873/#review46699
Attachment #8747382 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 61•8 years ago
|
||
Barbara, Margaret - I realized that there are two strings that this depends on, "Synced devices" and "%n devices". I could uplift this to 48 by using "Synced tabs" and leaving out "%n devices", or we could ask about breaking string freeze on aurora.
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
Comment 62•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ac956fe95aa3 https://hg.mozilla.org/integration/fx-team/rev/63ed19698b26 https://hg.mozilla.org/integration/fx-team/rev/0003c0e701e6 https://hg.mozilla.org/integration/fx-team/rev/5b048886e0c9 https://hg.mozilla.org/integration/fx-team/rev/af4e12a26b82 https://hg.mozilla.org/integration/fx-team/rev/bf0d533070d8 https://hg.mozilla.org/integration/fx-team/rev/7717106617ac https://hg.mozilla.org/integration/fx-team/rev/5bfba3bf6c1b https://hg.mozilla.org/integration/fx-team/rev/94f101332e2a https://hg.mozilla.org/integration/fx-team/rev/0a954f87f3ac https://hg.mozilla.org/integration/fx-team/rev/7bfd0b69bd9b https://hg.mozilla.org/integration/fx-team/rev/5acbf0da132a
Assignee | ||
Comment 63•8 years ago
|
||
Hi Delphine, I realized that we have two strings that we want to uplift with these patches, "Synced devices" and "%n devices". Let me know if we can get approval to break string freeze for them. This bug fixes some crashes and also updates our UI to re-include sync setup for people without accounts (which was removed in bug 1220928 which is on 48).
Flags: needinfo?(bbermes) → needinfo?(lebedel.delphine)
Comment 64•8 years ago
|
||
Thanks for reaching out :liuche. Yes, I think in this case is OK, but please try to uplift quickly. thanks!
Flags: needinfo?(lebedel.delphine)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(margaret.leibovic)
Assignee | ||
Comment 66•8 years ago
|
||
Was using a tablet and realized I'd only centered the smartfolder image but forgot to scale it. r=trivial
Assignee | ||
Comment 67•8 years ago
|
||
Attachment #8748020 -
Flags: review+
Comment 68•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ac956fe95aa3 https://hg.mozilla.org/mozilla-central/rev/63ed19698b26 https://hg.mozilla.org/mozilla-central/rev/0003c0e701e6 https://hg.mozilla.org/mozilla-central/rev/5b048886e0c9 https://hg.mozilla.org/mozilla-central/rev/af4e12a26b82 https://hg.mozilla.org/mozilla-central/rev/bf0d533070d8 https://hg.mozilla.org/mozilla-central/rev/7717106617ac https://hg.mozilla.org/mozilla-central/rev/5bfba3bf6c1b https://hg.mozilla.org/mozilla-central/rev/94f101332e2a https://hg.mozilla.org/mozilla-central/rev/0a954f87f3ac https://hg.mozilla.org/mozilla-central/rev/7bfd0b69bd9b https://hg.mozilla.org/mozilla-central/rev/5acbf0da132a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 69•8 years ago
|
||
Hi Carsten, I realized that I was probably remiss in landing the last patch in this series after/separate from the main series - can you also merge the "Scale smartfolder icon" patch? I'm sorry, I should have actually filed another bug for that.
Flags: needinfo?(cbook)
Assignee | ||
Comment 70•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: approval from :delphine for string changes
Flags: needinfo?(cbook)
Attachment #8743626 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 71•8 years ago
|
||
Comment on attachment 8744539 [details] MozReview Request: Bug 1261527 - Handle Configuration changes. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8744539 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 72•8 years ago
|
||
Comment on attachment 8744540 [details] MozReview Request: Bug 1261527 - Move code around. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8744540 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 73•8 years ago
|
||
Comment on attachment 8744541 [details] MozReview Request: Bug 1261527 - Add clear history button. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8744541 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 74•8 years ago
|
||
Comment on attachment 8746311 [details] MozReview Request: Bug 1261527 - Empty state for history only. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8746311 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 75•8 years ago
|
||
Comment on attachment 8746312 [details] MozReview Request: Bug 1261527 - Add active/inactive client state. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8746312 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 76•8 years ago
|
||
Comment on attachment 8746314 [details] MozReview Request: Bug 1261527 - Remove RemoteTabsExpandableListAdapter after extracting static methods. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8746314 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 77•8 years ago
|
||
Comment on attachment 8746315 [details] MozReview Request: Bug 1261527 - Add refresh layout. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8746315 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 78•8 years ago
|
||
Comment on attachment 8746824 [details] MozReview Request: Bug 1261527 - Update textsize and layout. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8746824 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 79•8 years ago
|
||
Comment on attachment 8747331 [details] MozReview Request: Bug 1261527 - Long-press on smartfolder. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8747331 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 80•8 years ago
|
||
Comment on attachment 8747382 [details] MozReview Request: Bug 1261527 - Clean up RecyclerView animations. r=sebastian Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8747382 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 81•8 years ago
|
||
Comment on attachment 8748020 [details] [diff] [review] Patch: Scale smartfolder icon Approval Request Comment [Feature/regressing bug #]: Next stage of bug 1220928 [User impact if declined]: New users will not have an entry point to sync from the History panel [Describe test coverage new/current, TreeHerder]: local, nightly [Risks and why]: lots of new code, but is simpler than what's on 48 and less crashy [String/UUID change made/needed]: none in this commit
Attachment #8748020 -
Flags: approval-mozilla-aurora?
Comment 82•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/01a1f0dc7c96
Assignee | ||
Comment 84•8 years ago
|
||
Hi Liz, not sure if this slipped through the cracks for aurora uplift requests, but just wanted to make sure it's on the radar. I'd like to get this uplifted sooner rather than later because there are some strings. Let me know if there are any problems, thanks!
Flags: needinfo?(lhenry)
Comment 85•8 years ago
|
||
Comment on attachment 8743626 [details] MozReview Request: Bug 1261527 - Combine Synced devices into a folder. r=sebastian Restructuring sync folder organization, many patches. Early aurora so this seems ok. String changes in one patch, approved by delphine.
Flags: needinfo?(lhenry)
Attachment #8743626 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8744539 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8744540 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8744541 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8746311 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8746312 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8746314 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8746315 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8746824 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8747331 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8747382 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Attachment #8748020 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 86•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/f0f7f315c215 https://hg.mozilla.org/releases/mozilla-aurora/rev/fea137d66b09 https://hg.mozilla.org/releases/mozilla-aurora/rev/edc81c1262fa https://hg.mozilla.org/releases/mozilla-aurora/rev/69886489143e https://hg.mozilla.org/releases/mozilla-aurora/rev/7cd6e6a653dd https://hg.mozilla.org/releases/mozilla-aurora/rev/e702eabb5ec7 https://hg.mozilla.org/releases/mozilla-aurora/rev/7e7a0d76f09c
Comment 87•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/fa7318ff115f https://hg.mozilla.org/releases/mozilla-aurora/rev/bd4d5fe4e576 https://hg.mozilla.org/releases/mozilla-aurora/rev/73b77e1a24e1 https://hg.mozilla.org/releases/mozilla-aurora/rev/26ed379a7971 https://hg.mozilla.org/releases/mozilla-aurora/rev/3fd3ddb07f07 https://hg.mozilla.org/releases/mozilla-aurora/rev/3d60e5a9eb9f
Comment 88•8 years ago
|
||
Thanks for the screenshot, me and Ludwig translated it for the Swedish version now
Comment 89•8 years ago
|
||
Release Note Request (optional, but appreciated) [Why is this notable]: [Suggested wording]: see release comments above [Links (documentation, blog post, etc)]:
relnote-firefox:
--- → ?
Comment 90•8 years ago
|
||
49+ for release note, added "New users will now have an entry point to sync from the History panel"
Comment 91•8 years ago
|
||
(In reply to Marcia Knous [:marcia - use ni] from comment #90) > 49+ for release note, added "New users will now have an entry point to sync > from the History panel" This was uplifted to 48.
Flags: needinfo?(mozillamarcia.knous)
Comment 92•8 years ago
|
||
Changing relnote flag based on Comment 91. Sylvestre - should this be added to 48 rel note?
relnote-firefox:
49+ → ---
Flags: needinfo?(mozillamarcia.knous) → needinfo?(sledru)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•