1261608 - Missing images in Insert Image dialog

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The images img-align-right.gif and img-align-top.gif are missing in Inser Image dialog in Align Text to Image menulist.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1261608.patch

Re-add the images which are removed in 2012.
[Approval Request Comment]
User impact if declined: no images in menulist
Testing completed (on c-c, etc.): not yet in c-c
Risk to taking this patch (and alternatives if risky): low, really simple jar.mn change

Comment 2

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/88b9c4886d20ea3d10be7508b22ec87e17569c5f
Bug 1261608 - Re-add missing img-align* images bacj to jar.mn. r=jorgk a=fix to avoid spurious errors in mozmill test bustage CLOSED TREE

Comment 3

[Jorg K (CEST = GMT+2)]

Aurora (TB 47):
https://hg.mozilla.org/releases/comm-aurora/rev/0ca649e66d7b

Comment 4

[Kent James (:rkent)]

"User impact if declined: no images in menulist" does not really give me enough information to understand the impact of this bug in TB 45.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: Picture showing the missing icon.

Well, it's hard to *show* something that's missing ;-)

If you exercise the alignment menu on the top right of the dialogue, you will see that some alignments have icons, two don't. This has now been fixed.

I trust that answers your question ;-)

Comment 6

[Kent James (:rkent)]

It's not the fact that something is missing that is the confusion, it is the use of generic terms. Something missing in "the menulist" or "the dialogue". It would be good if I did not have to look at the patch, and ultimately reproduce it myself, to figure out if this is a trivial or critical issue.

Please don't get me wrong, I am pleased that you are marking easy improvements for esr45, and I am happy to add them there.  But I would appreciate a little more detail in the "why?" this makes sense for uplift to esr45. I am not as close to this code as you are, so I need a "why for dummies".

Comment 7

[Kent James (:rkent)]

http://hg.mozilla.org/releases/comm-esr45/rev/6c2abd7938c4