1261649 - bug-1259490.js is going to permafail when Gecko 48 merges to Aurora

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafail when Gecko 48 merges to Aurora.

https://treeherder.mozilla.org/logviewer.html#?job_id=18975296&repo=try

14:40:05     INFO -  FAIL - gc/bug-1259490.js
14:40:05  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/gc/bug-1259490.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 SyntaxError: expected expression, got '*': (code 3, args "")
14:40:05     INFO -  INFO exit-status     : 3
14:40:05     INFO -  INFO timed-out       : False
14:40:05     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 SyntaxError: expected expression, got '*':
14:40:05     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16     uneval(-(0 ** (Object | 0 * Object)))
14:40:05     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 ................^
14:40:05     INFO -  /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 SyntaxError: expected expression, got '*':
14:40:05     INFO -  /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16     uneval(-(0 ** (Object | 0 * Object)))
14:40:05     INFO -  /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 ................^
14:40:05     INFO -  Exit code: 3

Comment 1

[Terrence Cole [:terrence]]

Attachment: allow_test_for_bug_1259490_on_aurora-v0.diff

Thanks for the heads up, Ryan!

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8737853 [details] [diff] [review]
allow_test_for_bug_1259490_on_aurora-v0.diff

Review of attachment 8737853 [details] [diff] [review]:
-----------------------------------------------------------------

This is ok by me, but honestly it seems pretty cluttered. Especially since you'll have to do nontrivial editing to undo the eval stuff once ** ships.

I guess I was thinking something more like

// ** is nightly only for now
try { eval("3 ** 4") } catch (e if e instanceof SyntaxError) { quit(); };
eval`

gczeal(8);	
for (var k = 0; k < 99; ++k) {	
  uneval(-(0 ** (Object | 0 * Object)))
}

`;

It's simple to remove, and it highlights the required feature at the top of the script. You can use Function if you prefer. And ok, so I like using SM-specific catch (e if ...) clauses which might get removed any day.

Come to think of it, we really ought to have something in jit-test/lib/prologue.js. Then it could be something like

// nightly only
require_syntax("3 ** 4");
`
SCRIPT
`;

but I guess that's another bug.

Comment 3

[Terrence Cole [:terrence]]

Yeah, that's way better, I'm going to use yours.

Comment 4

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca5d7ac54447ad3e0440c18b5fd799d94b8932da
Bug 1261649 - Do not use bare ** in a new test; r=sfink

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca5d7ac54447

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Adding blocking flag in case this reopens.