Closed Bug 1261649 Opened 4 years ago Closed 4 years ago

bug-1259490.js is going to permafail when Gecko 48 merges to Aurora

Categories

(Core :: JavaScript Engine, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- unaffected
firefox47 --- unaffected
firefox48 blocking fixed

People

(Reporter: RyanVM, Assigned: terrence)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafail when Gecko 48 merges to Aurora.

https://treeherder.mozilla.org/logviewer.html#?job_id=18975296&repo=try

14:40:05     INFO -  FAIL - gc/bug-1259490.js
14:40:05  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/gc/bug-1259490.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 SyntaxError: expected expression, got '*': (code 3, args "")
14:40:05     INFO -  INFO exit-status     : 3
14:40:05     INFO -  INFO timed-out       : False
14:40:05     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 SyntaxError: expected expression, got '*':
14:40:05     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16     uneval(-(0 ** (Object | 0 * Object)))
14:40:05     INFO -  INFO stderr         2> /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 ................^
14:40:05     INFO -  /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 SyntaxError: expected expression, got '*':
14:40:05     INFO -  /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16     uneval(-(0 ** (Object | 0 * Object)))
14:40:05     INFO -  /builds/slave/test/build/tests/jit-test/jit-test/tests/gc/bug-1259490.js:3:16 ................^
14:40:05     INFO -  Exit code: 3
Flags: needinfo?(terrence)
Severity: normal → critical
Thanks for the heads up, Ryan!
Assignee: nobody → terrence
Status: NEW → ASSIGNED
Flags: needinfo?(terrence)
Attachment #8737853 - Flags: review?(sphink)
Comment on attachment 8737853 [details] [diff] [review]
allow_test_for_bug_1259490_on_aurora-v0.diff

Review of attachment 8737853 [details] [diff] [review]:
-----------------------------------------------------------------

This is ok by me, but honestly it seems pretty cluttered. Especially since you'll have to do nontrivial editing to undo the eval stuff once ** ships.

I guess I was thinking something more like

// ** is nightly only for now
try { eval("3 ** 4") } catch (e if e instanceof SyntaxError) { quit(); };
eval`

gczeal(8);	
for (var k = 0; k < 99; ++k) {	
  uneval(-(0 ** (Object | 0 * Object)))
}

`;

It's simple to remove, and it highlights the required feature at the top of the script. You can use Function if you prefer. And ok, so I like using SM-specific catch (e if ...) clauses which might get removed any day.

Come to think of it, we really ought to have something in jit-test/lib/prologue.js. Then it could be something like

// nightly only
require_syntax("3 ** 4");
`
SCRIPT
`;

but I guess that's another bug.
Attachment #8737853 - Flags: review?(sphink) → review+
Yeah, that's way better, I'm going to use yours.
https://hg.mozilla.org/mozilla-central/rev/ca5d7ac54447
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Adding blocking flag in case this reopens.
You need to log in before you can comment on or make changes to this bug.