merge the various versions of setupComposeWin() in TB mozmill tests

RESOLVED FIXED in Thunderbird 48.0

Status

Thunderbird
Testing Infrastructure
--
enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 48.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

25.72 KB, patch
Magnus Melin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

2 years ago
The helper function setupComposeWin() exists in several tests in mail/test/mozmill/composition, with slight variations. But their purpose is the same. I propose to merge them into one function in test-compose-helpers.js.

I have the patch ready, but can't produce a successful try run due to bug 1261602 (crash in composition/test-image-insertion-dialog.js which may affect other tests in the folder).
(Assignee)

Comment 2

2 years ago
Created attachment 8737913 [details] [diff] [review]
patch

Thanks, pushed: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b8c83ed17a9e
Attachment #8737913 - Flags: review?(mkmelin+mozilla)
(Assignee)

Comment 3

2 years ago
Run seems successful (OS X and Win), excluding the known failures that ware fixed since (backing out the reply identity patch).
Status: NEW → ASSIGNED

Comment 4

2 years ago
Comment on attachment 8737913 [details] [diff] [review]
patch

Review of attachment 8737913 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, lgtm! r=mkmelin
Attachment #8737913 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/comm-central/rev/38259e9e74a91e197c67ad820a1163e8d26254b7
Bug 1261707 - merge the various versions of setupComposeWin() in TB mozmill tests. r=mkmelin a=aleth

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
You need to log in before you can comment on or make changes to this bug.