1261713 - Write unit tests for Switchboard logic

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1261713 - (Part 1) Add unit test for DeviceUuidFactory.java. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/44047/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44047/

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1261713 - (Part 2) Refactor isInExperiment and add unit test. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/44049/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44049/

Comment 3

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1261713 - (Part 3) Refactor and add tests for extra experiment values support. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/44051/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44051/

Comment 4

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1261713 - (Part 4) Add test for getActiveExperiments. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/44053/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44053/

Comment 5

[:Margaret Leibovic]

Similar to my comment in bug 1207719, I think we can do more here, but at least this is a start.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8737648 [details]
MozReview Request: Bug 1261713 - (Part 1) Add unit test for DeviceUuidFactory.java. r=sebastian

https://reviewboard.mozilla.org/r/44047/#review40631

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8737649 [details]
MozReview Request: Bug 1261713 - (Part 2) Refactor isInExperiment and add unit test. r=sebastian

https://reviewboard.mozilla.org/r/44049/#review40633

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8737650 [details]
MozReview Request: Bug 1261713 - (Part 3) Refactor and add tests for extra experiment values support. r=sebastian

https://reviewboard.mozilla.org/r/44051/#review40635

::: mobile/android/tests/background/junit4/src/com/keepsafe/switchboard/TestSwitchboard.java:57
(Diff revision 1)
> +        } catch (JSONException e) {
> +            fail();
> +        }

You can add the exception (or the generic "Exception") to the method signature and the test will fail if this (or any) exception is thrown.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8737651 [details]
MozReview Request: Bug 1261713 - (Part 4) Add test for getActiveExperiments. r=sebastian

https://reviewboard.mozilla.org/r/44053/#review40637

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Awesome :)

Comment 11

[:Margaret Leibovic]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d7d05e6dc94

Comment 12

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/ac533e9899b77da4dcb3683440a789cdf06b4fab
Bug 1261713 - (Part 1) Add unit test for DeviceUuidFactory.java. r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/ae1f2e223f22a0961192e4acf85280fdb445621e
Bug 1261713 - (Part 2) Refactor isInExperiment and add unit test. r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/27bd269e54937b99b0eef25ce849400a29c48fdb
Bug 1261713 - (Part 3) Refactor and add tests for extra experiment values support. r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/aedf35fb81d98ad4d53253f1abd680023f2848f1
Bug 1261713 - (Part 4) Add test for getActiveExperiments. r=sebastian

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac533e9899b7
https://hg.mozilla.org/mozilla-central/rev/ae1f2e223f22
https://hg.mozilla.org/mozilla-central/rev/27bd269e5493
https://hg.mozilla.org/mozilla-central/rev/aedf35fb81d9

Comment 14

[:Margaret Leibovic]

Comment on attachment 8737648 [details]
MozReview Request: Bug 1261713 - (Part 1) Add unit test for DeviceUuidFactory.java. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9

Comment 15

[:Margaret Leibovic]

Comment on attachment 8737649 [details]
MozReview Request: Bug 1261713 - (Part 2) Refactor isInExperiment and add unit test. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9

Comment 16

[:Margaret Leibovic]

Comment on attachment 8737650 [details]
MozReview Request: Bug 1261713 - (Part 3) Refactor and add tests for extra experiment values support. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9

Comment 17

[:Margaret Leibovic]

Comment on attachment 8737651 [details]
MozReview Request: Bug 1261713 - (Part 4) Add test for getActiveExperiments. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8737648 [details]
MozReview Request: Bug 1261713 - (Part 1) Add unit test for DeviceUuidFactory.java. r=sebastian

We decided to not uplift bug 1270929 to Beta, we'll let this one also ride the Aurora48 to Beta48 train.