Closed Bug 1261714 Opened 8 years ago Closed 8 years ago

Intermittent browser_toolbox_options_disable_js.js | A promise chain failed to handle a rejection: - Error: operation not possible on dead CPOW

Categories

(DevTools :: Framework, defect, P1)

Product:
DevTools
Component:
Framework
Type:
defect

Tracking

(e10s+, firefox48 fixed, firefox49 fixed, firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
e10s + ---
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: RyanVM, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [btpp-backlog])

Attachments

(1 file)

Bug 1261714 - Fix dead CPOW intermittent on browser_toolbox_options_disable_js.js .
58 bytes, text/x-review-board-request
jryans
: review+
Details
Priority: -- → P3
Whiteboard: [btpp-backlog]
This is now a top intermittent
Priority: P3 → P1
Assignee: nobody → chevobbe.nicolas
Comment on attachment 8768207 [details]
Bug 1261714 - Fix dead CPOW intermittent on browser_toolbox_options_disable_js.js .

https://reviewboard.mozilla.org/r/62506/#review59410

Looks good, thanks for working on it!

::: devtools/client/framework/test/browser_toolbox_options_disable_js.js:58
(Diff revision 1)
> -  executeSoon(function () {
> +  let onExecuteSoon = () => {
> +    return new Promise(function (resolve) {
> +      executeSoon(resolve);
> +    });
> +  };
> +  yield onExecuteSoon();

Use `waitForTick()` which does the same Promise wrap for you.
Comment on attachment 8768207 [details]
Bug 1261714 - Fix dead CPOW intermittent on browser_toolbox_options_disable_js.js .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62506/diff/1-2/
Fixed the change jryans asked and pushed again. 
TRY is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd5630a47f5e
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff46fbd4ef08
Fix dead CPOW intermittent on browser_toolbox_options_disable_js.js. r=jryans
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/e178424c2e2a
Fix dead CPOW intermittent on browser_toolbox_options_disable_js.js . r=jryans
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/5a6bbd20aa4d
Backed out changeset e178424c2e2a for landed already on m-i
https://hg.mozilla.org/mozilla-central/rev/ff46fbd4ef08
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: