1261736 - The context menu "Edit Conditional Breakpoint" has incorrect behavior

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P2)

Description

[magicp]

Attachment: Edit-Conditional-Breakpoint-has-incorrect-behavior.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160403030243

Steps to reproduce:

1. Start Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > Debugger
4. Select a dbg-source-item (e.g. contentSearchUI.js)
5. Add conditional breakpoint on any lines (e.g. line: 9)
6. Enter any expressions (e.g. true)
7. Close conditional-breakpoint-panel
8. Right-click on other line number (e.g. line: 10)
9. Confirm "Add Conditional Breakpoint" is displayed in context menu
10. Select same dbg-breakpoint-text again and close conditional-breakpoint-panel
11. Right-click on other line number (e.g. line: 11) 
12. Confirm "Add Conditional Breakpoint" is disappear 
13. Select "Edit Conditional Breakpoint" of context menu
 


Actual results:

Added conditional breakpoint still get focus and run "Edit Conditional Breakpoint". But New breakpoint is added.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=40ae8489939e21be81751a5e241f6ab7e2b4d9a2&tochange=c96ec660af96a187b62c5dd5f9bce62c0f2ffeb6


Expected results:

Which action for condition is enable?
(a) Focused conditional breakpoint
(b) Right-clicked line number

In case of (a), focused conditional-breakpoint-panel should be opened. And also don't add new breakpoint.
In case of (b), "Edit Conditional Breakpoint" should not be displayed in context menu. ("Add Conditional Breakpoint" is correct)

Comment 1

[Eddy Bruel [:ejpbruel]]

Jason, you made some changes in this area recently, didn't you? Could this have been caused by one of your recent patches? If so, could you investigate it?

Comment 2

[Jason Laster [:jlast]]

ejpruel, I definitely caused this regression. Previously, the context menu only ever said "add conditional breakpoint".

Comment 3

[Jason Laster [:jlast]]

This is no longer relevant given the new UI.