Closed
Bug 1261736
Opened 8 years ago
Closed 7 years ago
The context menu "Edit Conditional Breakpoint" has incorrect behavior
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(firefox48 affected, firefox49 affected)
RESOLVED
WONTFIX
People
(Reporter: magicp.jp, Assigned: jlast)
References
Details
Attachments
(1 file)
1.01 MB,
video/mp4
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160403030243 Steps to reproduce: 1. Start Nightly 2. Go to any sites (e.g. about:home) 3. Open DevTools > Debugger 4. Select a dbg-source-item (e.g. contentSearchUI.js) 5. Add conditional breakpoint on any lines (e.g. line: 9) 6. Enter any expressions (e.g. true) 7. Close conditional-breakpoint-panel 8. Right-click on other line number (e.g. line: 10) 9. Confirm "Add Conditional Breakpoint" is displayed in context menu 10. Select same dbg-breakpoint-text again and close conditional-breakpoint-panel 11. Right-click on other line number (e.g. line: 11) 12. Confirm "Add Conditional Breakpoint" is disappear 13. Select "Edit Conditional Breakpoint" of context menu Actual results: Added conditional breakpoint still get focus and run "Edit Conditional Breakpoint". But New breakpoint is added. Regression range: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=40ae8489939e21be81751a5e241f6ab7e2b4d9a2&tochange=c96ec660af96a187b62c5dd5f9bce62c0f2ffeb6 Expected results: Which action for condition is enable? (a) Focused conditional breakpoint (b) Right-clicked line number In case of (a), focused conditional-breakpoint-panel should be opened. And also don't add new breakpoint. In case of (b), "Edit Conditional Breakpoint" should not be displayed in context menu. ("Add Conditional Breakpoint" is correct)
Blocks: 900763
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox48:
--- → affected
Component: Untriaged → Developer Tools: Debugger
OS: Unspecified → All
Hardware: Unspecified → All
Comment 1•8 years ago
|
||
Jason, you made some changes in this area recently, didn't you? Could this have been caused by one of your recent patches? If so, could you investigate it?
Flags: needinfo?(jlaster)
Priority: -- → P3
Assignee | ||
Comment 2•8 years ago
|
||
ejpruel, I definitely caused this regression. Previously, the context menu only ever said "add conditional breakpoint".
Assignee: nobody → jlaster
Flags: needinfo?(jlaster)
Assignee | ||
Updated•8 years ago
|
Priority: P3 → P2
status-firefox49:
--- → affected
Assignee | ||
Comment 3•7 years ago
|
||
This is no longer relevant given the new UI.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•