Closed
Bug 1261738
Opened 8 years ago
Closed 8 years ago
Too many "FX_TAB_SWITCH_TOTAL_MS was already initialized" errors in tests
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
When tests trigger tab switches in quick succession, we wind up with a lot of overlapping tab switch stopwatches, and the resulting floods of errors make test output extremely difficult to deal with.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44061/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44061/
Attachment #8737668 -
Flags: review?(mconley)
Comment 3•8 years ago
|
||
Comment on attachment 8737668 [details] MozReview Request: Bug 1261738: Try to avoid overlapping FX_TAB_SWITCH_TOTAL_MS stopwatches. r?mconley https://reviewboard.mozilla.org/r/44061/#review40813 LGTM - thanks for plugging that. :) ::: browser/base/content/tabbrowser.xml:1020 (Diff revision 1) > <![CDATA[ > this.ownerDocument.title = this.getWindowTitleForBrowser(this.mCurrentBrowser); > ]]> > </body> > </method> > Mind adding a quick comment here explaining what this is being used for?
Attachment #8737668 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://reviewboard.mozilla.org/r/44061/#review40813 > Mind adding a quick comment here explaining what this is being used for? Sure.
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/99272d590c8ff6925f7b9c2471be88b0ba373174 Bug 1261738: Try to avoid overlapping FX_TAB_SWITCH_TOTAL_MS stopwatches. r=mconley
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/99272d590c8f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•