nsIFrame::GetCrossDocChildLists should return all subdoc root frames

RESOLVED INVALID

Status

()

Core
Layout
RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
It returns whatever happens to be the first view child of the inner view. If there are two views (like during navigation between pages) we miss one.

All existing users of this seem like this would be the correct thing to do. But my motivation is in the next patch posted in another bug.
(Assignee)

Updated

2 years ago
Blocks: 1261763
(Assignee)

Comment 1

2 years ago
(In reply to Timothy Nikkel (:tnikkel) from comment #0)
> All existing users of this seem like this would be the correct thing to do.
> But my motivation is in the next patch posted in another bug.

"another bug" is bug 1261763.
(Assignee)

Comment 2

2 years ago
Created attachment 8737708 [details] [diff] [review]
patch

I don't feel super great about letting there be more than one list with the id kSubDocumentList in the same array of ChildLists, but I couldn't figure out any better way to do it because each frame list has to be a true frame list that is linked to each other. The different subdocument root frames are not linked to each other.
Attachment #8737708 - Flags: review?(mats)
Comment on attachment 8737708 [details] [diff] [review]
patch

This just feels very very wrong to me.  Let's not mess with the meaning
of child frame lists please.

If we also have root views from previous navigations in BeginSwapDocShells
let's just deal with that situation there (in bug 1261763).
Attachment #8737708 - Flags: review?(mats) → review-
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.