Closed Bug 1261800 Opened 8 years ago Closed 8 years ago

NSS tests skip list entry "ssl_gtest" shouldn't cause a skip of "ssl"

Categories

(NSS :: Test, defect)

defect
Not set
normal

Tracking

(firefox48 affected)

RESOLVED DUPLICATE of bug 1009429
Tracking Status
firefox48 --- affected

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(1 file)

As of today, the skip list testing in NSS uses grep with default parameters, which allows sub matches.

As a result, the test for "ssl" will decide to skip, if the skip list configuration contains "ssl_gtest".

The suggested fix is to test for full word matches using grep -w
Attached patch 1261800-v1.patchSplinter Review
Assignee: nobody → kaie
Attachment #8737739 - Flags: review?(emaldona)
My patch was for NSS 3.21

I notice this issue has already been fixed by Bob in NSS 3.22 in bug 1009429 using a different approach:

        # NOTE: the spaces are important. If you don't include
        # the spaces, then turning off ssl_gtests will also turn off ssl
        # tests.
        echo " ${TESTS_SKIP} " | grep " ${TEST} " > /dev/null
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Attachment #8737739 - Flags: review?(emaldona)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: