1261843 - Two conversation can be opened while the new Sharing panel is shown

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

Attachment: Screencast showing the issue

[Affected versions]:
- Firefox 46 beta 7 
- latest Developer Edition 47.0a2
- latest Nightly 48.0a1

[Affected platforms]:
- Windows 7 64-bit
- Windows XP 32-bit
- Mac OS X 10.10.5
- Ubuntu 14.04 64-bit

[Steps to reproduce]:
1. Start Firefox
2. Make sure you have another conversation in Hello panel
3. Click 'Browse this page with a friend'
4. Before Share panel shows up click the conversation that's displayed in Hello panel
- If two conversation did not open at the same time an additional step is required:
5. Click Hello Panel.

[Expected result]:
- While the transition to Share panel, user can't access other conversations

[Actual result]:
- Two conversation are opened. After step 5 the Share panel is displayed over Disconnect button and also after closing one conversation (does not matter which one) Disconnect button will not show up anymore in Hello Panel.

[Regression range]:
- This is not a regression, it reproduces since Share panel was introduced.

[Additional notes]:
- Screencast attached showing the issue.
- Firefox 45.0.1 is not affected since it does not have this panel.

Comment 1

[Andrei Vaida [:avaida]]

[Tracking Requested - why for this release]:
Easily reproducible issue affecting the Hello user experience on Fx46.

Comment 2

[Mark Banner (:standard8)]

Bumping this up a bit, as I think we should fix it reasonably soon, as the effects with the share panel not opening straight away are quite apparent.

Comment 3

[GitHub Autolander Bot]

Attachment: [loop] Mardak:bug-1261843-double > mozilla:master

Comment 4

[Ed Lee :Mardak]

Comment on attachment 8738159 [details] [review]
[loop] Mardak:bug-1261843-double > mozilla:master

Test incoming to set state and check the class is set.

Comment 5

[Ed Lee :Mardak]

Attachment: v1 video

Showing that the list gets disabled on create room.

Comment 6

[David Critchley (:dcritch)]

Comment on attachment 8738159 [details] [review]
[loop] Mardak:bug-1261843-double > mozilla:master

Looks good

Comment 7

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/9741a608303cefbe49f3611bb5a4752bba632b6d

Comment 8

[Ed Lee :Mardak]

Oops. Thanks for pasting the commit and resolving.

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

This has been fixed in 47 and 48 in bug 1262522.