Closed Bug 1261849 Opened 7 years ago Closed 7 years ago

Hello conversation opens while Firefox is in never remember history mode

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox45 affected, firefox46 affected, firefox47 affected, firefox48 affected)

RESOLVED FIXED
Tracking Status
firefox45 --- affected
firefox46 --- affected
firefox47 --- affected
firefox48 --- affected

People

(Reporter: bogdan_maris, Assigned: mancas)

References

Details

(Whiteboard: [btpp-fix-now][47])

Attachments

(2 files)

[Affected versions]:
- Firefox 45.0
- Firefox 46 beta 7
- latest Developer Edition 47.0a2
- latest Nightly 48.0a1

[Affected platforms]:
- Windows 7 64-bit
- Windows XP 32-bit
- Mac OS X 10.10.5
- Ubuntu 14.04 64-bit

[Steps to reproduce]:
1. Start Firefox
2. Start a conversation
3. Set Firefox not to remember history
(about:preferences#privacy)
4. Visit https://www.mozilla.org/en-US/firefox/hello/
5. Click 'Try hello' button

[Expected result]:
- Hello does not start a conversation.

[Actual result]:
- A conversation is started, conversation window does not open anywhere but if you click 'Try Firefox Hello' button again, Disconnect button is shown, but does nothing.

[Regression range]:
- Not sure if this is a regression range, will come with an update ASAP.
Though I think that this was since forever, it reproduces with 0.1 as well.

[Additional notes]:
- Screencast showing the issue attached
Rank: 19
Priority: -- → P1
Whiteboard: [btpp-fix-now]
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #0)
> [Regression range]:
> - Not sure if this is a regression range, will come with an update ASAP.
> Though I think that this was since forever, it reproduces with 0.1 as well.

As I thought so, this is not a regression, I was able to reproduce this with the Nightly from 2015-10-30 as well (first Nightly 45.0a1 build). With previous Nightly build (last Nightly 44.0a1) I was not able to reproduce since 'Try hello' button is not available on https://www.mozilla.org/en-US/firefox/hello/, only a Download button saying to upgrade my Firefox.
It looks like the toolbar button is inactive (empty) not allowing clicks for the panel, but the page and menuitem under tools can trigger the panel.
Nevermind the menu comment -- tested on an outdated version.
This is what's eventually calling bootstrap.js's WindowListener.setupBrowserUI/LoopUI.openPanel:
https://dxr.mozilla.org/mozilla-central/source/browser/components/uitour/UITour.jsm#1720-1742

Simple fix is to check if private browsing and.... resolve/reject the promise?
With the simple fix from comment 4, the user clicking on the in-content button would feel like things are broken as nothing happens.
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
Attachment #8739323 - Flags: review?(standard8)
Attachment #8739323 - Flags: review?(edilee)
Comment on attachment 8739323 [details] [review]
[loop] mancas:bug1261849 > mozilla:master

A mochitest would be good and investigating if we should use resolve/reject (although I have a feeling that we'll need to continue using resolve to fit the existing UITour codepath).
Attachment #8739323 - Flags: review?(standard8)
Attachment #8739323 - Flags: review?(edilee)
Attachment #8739323 - Flags: review+
Rank: 19 → 10
Whiteboard: [btpp-fix-now] → [btpp-fix-now][47]
I left a comment on github
Flags: needinfo?(edilee)
Attachment #8739323 - Flags: review?(standard8)
Attachment #8739323 - Flags: review?(standard8) → review+
Landed in  master: https://github.com/mozilla/loop/commit/20c3a0159da4c908a126db1d046254f312d0f22b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(edilee)
Resolution: --- → FIXED
Blocks: 1267835
You need to log in before you can comment on or make changes to this bug.