1261873 - windows 7 cpu/mem counters are showing up as values of 0 after changing the process names

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in bug 1114647 a lot of work was done to change the process names for the child process, but in the act of doing so it appears we have missing data:
https://treeherder.mozilla.org/perf.html#/alerts?id=708

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

ni myself to ensure that I follow up here- so far I have been putting print statements in cmanager_win32.py to determine what is getting registered, it appears that on the first counter that we register, we never complete the addition of it, somehow we are hanging in a loop and never registering other counters in the loop, nor finishing the registration which then causes us to never start collecting.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: MozReview Request: Bug 1261873 - windows 7 cpu/mem counters are showing up as values of 0 after changing the process names. r?wlach

Review commit: https://reviewboard.mozilla.org/r/44557/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44557/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

we were throwing an exception in code that effectively looks like:
expanededCounters = None
expandedCounters.append(...)


this is easy to solve and when we do we go back to our previous values.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8738480 [details]
MozReview Request: Bug 1261873 - windows 7 cpu/mem counters are showing up as values of 0 after changing the process names. r?wlach

https://reviewboard.mozilla.org/r/44557/#review41285

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70e457189e30

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70e457189e30