windows 7 cpu/mem counters are showing up as values of 0 after changing the process names

RESOLVED FIXED in Firefox 48

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Unassigned)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
in bug 1114647 a lot of work was done to change the process names for the child process, but in the act of doing so it appears we have missing data:
https://treeherder.mozilla.org/perf.html#/alerts?id=708
(Reporter)

Comment 1

3 years ago
ni myself to ensure that I follow up here- so far I have been putting print statements in cmanager_win32.py to determine what is getting registered, it appears that on the first counter that we register, we never complete the addition of it, somehow we are hanging in a loop and never registering other counters in the loop, nor finishing the registration which then causes us to never start collecting.
Flags: needinfo?(jmaher)
(Reporter)

Comment 2

3 years ago
Created attachment 8738480 [details]
MozReview Request: Bug 1261873 - windows 7 cpu/mem counters are showing up as values of 0 after changing the process names. r?wlach

Review commit: https://reviewboard.mozilla.org/r/44557/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44557/
Attachment #8738480 - Flags: review?(wlachance)
(Reporter)

Comment 3

3 years ago
we were throwing an exception in code that effectively looks like:
expanededCounters = None
expandedCounters.append(...)


this is easy to solve and when we do we go back to our previous values.
Flags: needinfo?(jmaher)
Comment on attachment 8738480 [details]
MozReview Request: Bug 1261873 - windows 7 cpu/mem counters are showing up as values of 0 after changing the process names. r?wlach

https://reviewboard.mozilla.org/r/44557/#review41285
Attachment #8738480 - Flags: review?(wlachance) → review+

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/70e457189e30
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.