Closed Bug 1261918 Opened 4 years ago Closed 4 years ago

Error in parsing value for 'height' in chrome://messenger/content/newmailaccount/accountProvisioner.xhtml

Categories

(Thunderbird :: Account Manager, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 48.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

Warning: Error in parsing value for 'height'.  Declaration dropped.
Source File: chrome://messenger/content/newmailaccount/accountProvisioner.xhtml
Line: 0
Source Code: 479

The code line is bogus, but the code is like this:
 document.getElementById("window").style.height = window.innerHeight - 1;
Attached patch patchSplinter Review
It seems the pattern throughout /mail is to also specify units 'px' when setting style.height.
Attachment #8737902 - Flags: review?(richard.marti)
Comment on attachment 8737902 [details] [diff] [review]
patch

looks good and removes the error.
Attachment #8737902 - Flags: review?(richard.marti) → review+
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4a5efadf639bdc9851bd4c3ad6a87bb10a77dbfc
Bug 1261918 - set .style.height in accountProvisioner.js also specifying units. r=Paenglab
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
You need to log in before you can comment on or make changes to this bug.