Closed Bug 1261943 Opened 4 years ago Closed 4 years ago

clean up TB mozmill tests using the account wizard

Categories

(Thunderbird :: Testing Infrastructure, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 48.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file, 1 obsolete file)

14.77 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review
I've found these 3 mozmill tests that use the account wizard and use a server config file to determine the account configuration:
mozmill/account/test-mail-account-setup-wizard.js
mozmill/account/test-retest-config.js
mozmill/instrumentation/test-instrument-setup.js

I propose to clean them up a bit. Some imports can be removed, some boilerplate code shortened.
Also they use mozmill/account/html/ and mozmill/account/xml/ to store the server config files. That is, 2 folders for the same thing (a xml config file). This can be merged.
Comment on attachment 8737936 [details] [diff] [review]
patch

Review of attachment 8737936 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, except the .com -> .invalid changes

::: mail/test/mozmill/account/test-mail-account-setup-wizard.js
@@ +69,5 @@
>    let url = collector.addHttpResource("../account/xml", "autoconfig");
>    Services.prefs.setCharPref(pref_name, url);
>  
>    // Force .com MIME-Type to text/xml
> +  collector.httpd.registerContentType("invalid", "text/xml");

Why this change? example.com is actually a real domain reserved for testing usage
Attachment #8737936 - Flags: review?(mkmelin+mozilla)
Yes, it is a real domain that can be looked up and does exist. .invalid does not really exist so we may avoid hitting the network accidentaly. But I can revert it back if you wish, it is not critically needed to solve the bug.
Yes please.
Attached patch patch v2Splinter Review
OK. Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5cea96548d7bae9d2c415059e3eb266a4e616d24
Attachment #8737936 - Attachment is obsolete: true
Attachment #8741053 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8741053 [details] [diff] [review]
patch v2

Review of attachment 8741053 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin
Attachment #8741053 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/fa8bc44ffbb8136426fbe814c5794b435fad8a5e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
You need to log in before you can comment on or make changes to this bug.