1261981 - [infer] Errors in LocalBrowserDB

Status: RESOLVED INACTIVE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

/var/lib/jenkins/workspace/fennec-infer/mobile/android/base/java/org/mozilla/gecko/db/LocalBrowserDB.java:618: error: NULL_DEREFERENCE
  object cursor last assigned on line 615 could be null and is dereferenced at line 618

/var/lib/jenkins/workspace/fennec-infer/mobile/android/base/java/org/mozilla/gecko/db/LocalBrowserDB.java:1697: error: NULL_DEREFERENCE
  object topSitesCursor last assigned on line 1683 could be null and is dereferenced at line 1697

Comment 1

[swaroop.rao]

I've got a patch ready for this. Who should I assign the review to in the commit message? Should it be r?rcomella or r?sebastian ?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Please r?sebastian – I'm no longer working on Fennec.

Comment 3

[Maurya Talisetti]

Hi Michael,

How is infer run on the project?

infer run -- ./gradlew build ---> Throws an error about mach. The below options don't work either.

infer run -- ./mach build
infer run -- gradle build

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Maurya Talisetti from comment #3)
> How is infer run on the project?

I actually never got it to run locally – Sylvestre ran it in various forms of CI.

In the infer meta bug 1175203 comment 0, I found [1], which looks like the current place we're running it (click the bugs.txt artifact). I updated the docs at [2] accordingly.

fwiw, I used to use a tool [3] to filter the infer results only to things we cared about but I'm not sure if it's necessary anymore.

[1]: http://relman-ci.mozilla.org/job/fennec-infer/
[2]: https://wiki.mozilla.org/Mobile/Fennec/Android/Testing/Not_yet_in_common_use#Facebook_Infer

[3]: https://github.com/mcomella/infer-filter

Comment 5

[Sylvestre Ledru [:Sylvestre]]

We run it now at review phase.
No action for a while, closing.