1261995 - [infer] Errors in push

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

/var/lib/jenkins/workspace/fennec-infer/mobile/android/services/src/main/java/org/mozilla/gecko/push/autopush/AutopushClient.java:150: error: NULL_DEREFERENCE
  object returned by body.getLong("code") could be null and is dereferenced at line 150

/var/lib/jenkins/workspace/fennec-infer/mobile/android/services/src/main/java/org/mozilla/gecko/push/autopush/AutopushClient.java:151: error: NULL_DEREFERENCE
  object returned by body.getLong("errno") could be null and is dereferenced at line 151

Nick, mind taking a look?

Comment 1

[Nick Alexander :nalexander [he/him]]

https://dxr.mozilla.org/mozilla-central/rev/d9f50aa0a1aaf90499b85c31e0f329b762e80fdd/mobile/android/services/src/main/java/org/mozilla/gecko/push/autopush/AutopushClient.java#147 shows:

            // TODO: The service doesn't do the right thing yet :(
            // body.throwIfFieldsMissingOrMisTyped(requiredErrorStringFields, String.class);
            // body.throwIfFieldsMissingOrMisTyped(requiredErrorLongFields, Long.class);

Patch inbound.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1261995 - Quiet infer NullPointerException warnings. r?mcomella

Review commit: https://reviewboard.mozilla.org/r/44445/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44445/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8738315 [details]
MozReview Request: Bug 1261995 - Quiet infer NullPointerException warnings. r?mcomella

https://reviewboard.mozilla.org/r/44445/#review43163

::: mobile/android/services/src/main/java/org/mozilla/gecko/push/autopush/AutopushClient.java:151
(Diff revision 1)
>          String info;
>          ExtendedJSONObject body;
>          try {
>              body = new SyncStorageResponse(response).jsonObjectBody();
>              // TODO: The service doesn't do the right thing yet :(
>              // body.throwIfFieldsMissingOrMisTyped(requiredErrorStringFields, String.class);

nit: not sure why this is still uncommented, but I'll go with it

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/3e85a84c7d68632e1098cc9374787dc8f54ce24f
Bug 1261995 - Quiet infer NullPointerException warnings. r=mcomella

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I think it really can be uncommented, considering it's a generic method checking types, but I don't want this to break without Nick around.

fwiw, fixing this could be a good first bug.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #5)
> I think it really can be uncommented, considering it's a generic method
> checking types, but I don't want this to break without Nick around.
> 
> fwiw, fixing this could be a good first bug.

It throws because the service is (wrongly!) not including them when it should.  Try it; uncomment the @Ignore line at https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/background/junit4/src/org/mozilla/gecko/push/autopush/test/TestLiveAutopushClient.java#36 and run the tests.  (You may need to hand-hack the set of cipher suites -- just remove all the 20+ ones or something.)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e85a84c7d68