126201 - incorrect wording for COMPLETE setup option

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Patrick]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.8+)
Gecko/20020218
BuildID:    2002021803

The (windows) installer gives you several installation options.
One of them is to do a "COMPLETE" Mozilla installation. The information with
this option tell us that the "program will be installed with the most common
options"

IMHO "complete" and "most common" is not the same. Therefore "most common"
should be replaced by something that reflects the "completeness" of installation

Reproducible: Always
Steps to Reproduce:
1.install mozilla
2.
3.

Actual Results:  consistent wording

Expected Results:  inconsistent wording

probably affects other OS as well, but couldn't check for that.

Comment 1

[Daniel Veditz [:dveditz]]

Very true, accepting.  Must've happened when "Recommended" and "Complete" were
collapsed into a single option for Mozilla.

Now that there are extra hacker tools like Venkman and DOM Inspector a
distinction makes a little more sense, although dropping those from a
"Recommended" type would only save 350k on the download. I guess we'll stick
with "Complete" and just fix the wording.

Comment 2

[Patrick]

Cleaning up my old bug reports i noticed this one.
I see it doesn't have a target milestone yet. Since this seems like a minor
thing to change it might be nice to do it before the big 1.0 is released?

(i don't know if i'm allowed to change target milestones?)

Comment 3

[dcary]

In my opinion, the default option should be to install everything. So Mozilla
Setup should ask something like:

---
Click the type of setup you prefer ...
() Browser only: Only the browser component will be installed.
() Complete: All components will be installed.
() Custom: You may choose the components you want ....
---

I say ``components'', not ``options''. I think this is more consistent with
terminology elsewhere in Mozilla, where a ``component'' is executable code that
is installed once and then never changes, while ``options'' are selections in
some Prefs menu, which (can) change some data file every time I run Mozilla.

I assume that ``Complete'' does, in fact, install all the components. Am I right
? If I'm not right, we need to change it to "Recommended".

(I'm seeing this on Mozilla 1.1a on Win98, build 2002061104)

Comment 4

[dcary]

While you're fixing wording, maybe this would be easy to fix (or do I need to
file a separate bug report ?):

When I choose ``Custom'', then later Mozilla Setup informs me that the
``Personal Security Manager'' is
``for secure browsing and email; required for SSL (https) and
''.

And what ?

(I saw this while installing Mozilla 1.1a on Win98, build 2002061104)

Comment 5

[dcary]

I see that bug 76859 describes the same confusion on the Mac side.

Comment 6

[dcary]

Today I installed Mozilla 1.3b on Windows98. I'm still seeing the inconsistent
wording the original poster complained about a year ago.

Comment 7

[dcary]

Today I installed the latest nightly version of Mozilla 1.6 on Windows XP.

I'm still seeing the inconsistent
wording the original poster complained about 2 years ago.

I still agree with comment 3 -- the default should be
"() Complete: All components will be installed.".

Comment 8

[Patrick]

Attachment: Patch v1

Patch fixes the following files:
/xpinstall/packager/build/win/mozilla/config.it
/xpinstall/packager/os2/config.it
/xpinstall/packager/windows/config.it

Comment 9

[Patrick]

biesi: can you look at this patch? 

I don't know who's supposed to be reviewing Seamonkey patches like this anymore :S

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 177882 [details] [diff] [review]
Patch v1

r/sr=dveditz

I slightly prefer "all options" to "all the options", but it's fine either way.

Comment 11

[Patrick]

(In reply to comment #10)
> I slightly prefer "all options" to "all the options", but it's fine either way.

i used that wording for consistency. The "custom" [Setup Type2] option in those
files also uses "all the options".

Can someone check this in?

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, this wasn't my patch, I just asked for review per comment 9

I checked this in:
Checking in xpinstall/packager/build/win/mozilla/config.it;
/cvsroot/mozilla/xpinstall/packager/build/win/mozilla/config.it,v  <--  config.it
new revision: 1.2; previous revision: 1.1
done
Checking in xpinstall/packager/os2/config.it;
/cvsroot/mozilla/xpinstall/packager/os2/config.it,v  <--  config.it
new revision: 1.21; previous revision: 1.20
done
Checking in xpinstall/packager/windows/config.it;
/cvsroot/mozilla/xpinstall/packager/windows/config.it,v  <--  config.it
new revision: 1.144; previous revision: 1.143
done

Comment 13

[Anne (:annevk)]

This was FIXED, right?