Intermittent browser_dbg_stack-03.js | Test timed out - after DevToolsUtils.assert threw an exception: Error: Assertion failure: Should have an event loop. in browser_dbg_debugger-statement.js

RESOLVED FIXED in Firefox 48

Status

P3
normal
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: KWierso, Assigned: jlast)

Tracking

({intermittent-failure})

unspecified
Firefox 49
intermittent-failure

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Eddy, do you know what could be causing this?  Its our #2 orange at the moment.
Flags: needinfo?(ejpbruel)
No, but I'll take a look at it next week.
Assignee: nobody → ejpbruel
Flags: needinfo?(ejpbruel)
37 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 21
* fx-team: 11
* mozilla-central: 3
* try: 2

Platform breakdown:
* osx-10-10: 10
* linux64: 9
* osx-10-6: 7
* linux32: 5
* windowsxp: 2
* windows8-64: 2
* windows7-32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-08&endday=2016-04-08&tree=all
25 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 8
* mozilla-inbound: 7
* mozilla-central: 6
* try: 4

Platform breakdown:
* windows7-32: 6
* osx-10-6: 6
* osx-10-10: 4
* windowsxp: 3
* windows8-64: 3
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-09&endday=2016-04-09&tree=all
87 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 36
* fx-team: 28
* mozilla-central: 14
* try: 9

Platform breakdown:
* osx-10-10: 19
* osx-10-6: 18
* linux64: 16
* windows8-64: 11
* windows7-32: 10
* windowsxp: 7
* linux32: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-04&endday=2016-04-10&tree=all
34 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 19
* try: 6
* fx-team: 6
* mozilla-central: 2
* mozilla-beta: 1

Platform breakdown:
* osx-10-10: 8
* osx-10-6: 6
* linux64: 6
* windows7-32: 5
* linux32: 5
* windowsxp: 2
* windows8-64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-11&endday=2016-04-11&tree=all
(Assignee)

Updated

3 years ago
Assignee: ejpbruel → jlaster
44 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 29
* fx-team: 8
* mozilla-central: 6
* mozilla-aurora: 1

Platform breakdown:
* osx-10-10: 18
* osx-10-6: 8
* linux64: 7
* windows8-64: 5
* windowsxp: 3
* windows7-32: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-12&endday=2016-04-12&tree=all
Summary: Intermittent browser_dbg_stack-03.js | Test timed out - after DevToolsUtils.assert threw an exception: Error: Assertion failure: Should have an event loop. → Intermittent browser_dbg_stack-03.js | Test timed out - after DevToolsUtils.assert threw an exception: Error: Assertion failure: Should have an event loop. in browser_dbg_debugger-statement.js
43 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 21
* fx-team: 16
* mozilla-central: 5
* try: 1

Platform breakdown:
* osx-10-6: 16
* osx-10-10: 11
* linux64: 5
* windows8-64: 4
* windows7-32: 4
* linux32: 2
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-13&endday=2016-04-13&tree=all
Jason said he wanted to take a stab at this, so I let him take the bug.
Priority: -- → P3
42 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 19
* fx-team: 17
* mozilla-central: 6

Platform breakdown:
* osx-10-6: 14
* osx-10-10: 12
* windows7-32: 6
* linux64: 4
* linux32: 3
* windowsxp: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-14&endday=2016-04-14&tree=all
(Assignee)

Comment 11

3 years ago
Created attachment 8741802 [details] [diff] [review]
intermittent.1.patch

I believe the intermittent came from the stack frame scrolling, which at the wrong time could attempt to fetch call stack frames, while the debugger is resuming. This is fixed by stopping the scrolling before resuming the debugger.

There are also two small refactors:

1. refactored tests to use Task.spawn/yield
2. converted gThreadClient.resume/closeDebugger to resumeDebuggerThenCloseAndFinish
Attachment #8741802 - Flags: review?(ejpbruel)
51 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 26
* fx-team: 17
* mozilla-central: 6
* try: 1
* mozilla-aurora: 1

Platform breakdown:
* osx-10-6: 13
* osx-10-10: 11
* windows8-64: 8
* linux64: 8
* windows7-32: 5
* windowsxp: 4
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-15&endday=2016-04-15&tree=all
256 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 131
* fx-team: 80
* mozilla-central: 30
* try: 12
* mozilla-aurora: 2
* mozilla-beta: 1

Platform breakdown:
* osx-10-10: 74
* osx-10-6: 68
* linux64: 35
* windows7-32: 26
* windows8-64: 25
* linux32: 15
* windowsxp: 13

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-11&endday=2016-04-17&tree=all
42 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 27
* fx-team: 11
* mozilla-central: 4

Platform breakdown:
* osx-10-10: 16
* linux64: 10
* osx-10-6: 8
* windows7-32: 3
* windowsxp: 2
* windows8-64: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-18&endday=2016-04-18&tree=all
Comment on attachment 8741802 [details] [diff] [review]
intermittent.1.patch

Review of attachment 8741802 [details] [diff] [review]:
-----------------------------------------------------------------

How did you figure this one out? I'm quite impressed by how quickly you managed to come up with a patch. Thanks for taking this bug off my plate!

On a side note, for small refactors that still touch on a lot of lines, such as refactoring a test to Task.jsm, I prefer it if you do that in a separate patch. If you put it all in a single patch it obscures the thing you were actually trying to fix.

::: devtools/client/debugger/test/mochitest/browser_dbg_stack-03.js
@@ +12,4 @@
>  
>  function test() {
>    initDebugger(TAB_URL).then(([aTab, aDebuggee, aPanel]) => {
> +    const gTab = aTab;

The g prefix is used for global variables. I never really liked that prefix to begin with, and since these variables are no longer global, you should probably just remove it.

@@ +21,3 @@
>  
> +    Task.spawn(function*() {
> +      gFramesScrollingInterval = window.setInterval(() => {

This looks like it doesn't have to be a global anymore either, does it?

@@ +46,5 @@
>          "Should have reached the recurse limit.");
>        is(gClassicFrames.itemCount, gDebuggee.gRecurseLimit,
>          "Should have reached the recurse limit in the mirrored view as well.");
>  
> +      window.clearInterval(gFramesScrollingInterval);

Please put a comment here explaining why this needs to happen in this specific order.
Attachment #8741802 - Flags: review?(ejpbruel) → review+
47 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 20
* fx-team: 20
* mozilla-central: 6
* try: 1

Platform breakdown:
* osx-10-10: 20
* osx-10-6: 9
* windowsxp: 5
* windows7-32: 5
* linux64: 4
* windows8-64: 3
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-19&endday=2016-04-19&tree=all
23 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 21
* fx-team: 2

Platform breakdown:
* windows7-32: 5
* osx-10-6: 5
* linux64: 4
* osx-10-10: 3
* windowsxp: 2
* windows8-64: 2
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-20&endday=2016-04-20&tree=all
124 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 73
* fx-team: 34
* mozilla-central: 11
* try: 5
* mozilla-aurora: 1

Platform breakdown:
* osx-10-10: 45
* osx-10-6: 26
* linux64: 20
* windows7-32: 13
* windowsxp: 9
* windows8-64: 7
* linux32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1262014&startday=2016-04-18&endday=2016-04-24&tree=all
(Assignee)

Comment 19

3 years ago
Created attachment 8744904 [details] [diff] [review]
intermittent.2.patch
Attachment #8741802 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
For future reference, the commit message in your patch should be summarizing what it's actually doing rather than restating the problem being fixed.
Flags: needinfo?(jlaster)

Comment 22

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86de03b543e9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Updated

3 years ago
Target Milestone: Firefox 48 → Firefox 49
(Assignee)

Comment 24

3 years ago
Thanks Ryan.
Flags: needinfo?(jlaster)

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.