Update description subtitle for Settings groups

VERIFIED FIXED in Firefox 48

Status

()

defect
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: antlam, Assigned: Margaret)

Tracking

(Blocks 1 bug)

unspecified
Firefox 48
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 verified)

Details

Attachments

(1 attachment)

Menu > Settings

The subtitles/descriptions in our top level Settings page are inconsistent some of these are outdated as well. For example, there isn't anything to do with the "URL bar" inside General.

Suggested: 
---
General
Home, language, tab queue

Search
Add, set default, show suggestions

Privacy
Tracking, logins, data choices

Accessibility
Text size, magnify small areas, voice input

Notifications
New features, website updates

Advanced
Restore tabs, show images, developer tools
Assignee

Updated

3 years ago
Assignee: nobody → margaret.leibovic
I guess we can fold bug 1261819 into this one?
Assignee

Comment 2

3 years ago
(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> I guess we can fold bug 1261819 into this one?

You're right, it would probably make sense to just write one patch for this. I was just going to pick this up myself, but you can also take it if you want :)
Assignee

Comment 3

3 years ago
(In reply to Anthony Lam (:antlam) from comment #0)

> Accessibility
> Text size, magnify small areas, voice input

"Magnify small areas" is still behind a Nightly flag. We shouldn't include this in the summary.

I think we should keep this as "Text size, zoom, voice input".

Are we tracking the fact that the zoomed view is only enabled on Nightly? I feel like we need to decide to prioritize it, or just remove it completely. But that's another issue.
Flags: needinfo?(bbermes)
Flags: needinfo?(alam)
(In reply to :Margaret Leibovic from comment #3)
> (In reply to Anthony Lam (:antlam) from comment #0)
> 
> > Accessibility
> > Text size, magnify small areas, voice input
> 
> "Magnify small areas" is still behind a Nightly flag. We shouldn't include
> this in the summary.
> 
> I think we should keep this as "Text size, zoom, voice input".

WFM!

Also via, IRC -

Advanced
Restore tabs, data saver, developer tools
Flags: needinfo?(alam)

Comment 6

3 years ago
Comment on attachment 8741460 [details]
MozReview Request: Bug 1262032 - Update description subtitle for Settings groups. r=sebastian

https://reviewboard.mozilla.org/r/46499/#review43111

This didn't need changing?

Notifications
New features, website updates
Attachment #8741460 - Flags: review+
Assignee

Comment 7

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/276092dfe88d39f27247a2c103842eab3a7e0cab
Bug 1262032 - Update description subtitle for Settings groups. r=sebastian
Assignee

Comment 8

3 years ago
(In reply to :Grisha Kruglov from comment #6)
> Comment on attachment 8741460 [details]
> MozReview Request: Bug 1262032 - Update description subtitle for Settings
> groups. r=sebastian
> 
> https://reviewboard.mozilla.org/r/46499/#review43111
> 
> This didn't need changing?
> 
> Notifications
> New features, website updates

No, sebastian already handled this in bug 1261819.

Sorry I didn't notice you reviewed this instead of sebastian! I'm too lazy to update the commit message, since I already pushed the patch.

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/276092dfe88d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment on attachment 8741460 [details]
MozReview Request: Bug 1262032 - Update description subtitle for Settings groups. r=sebastian

I already reviewed this yesterday. No clue why reviewboard didn't update the bugzilla flag.
Attachment #8741460 - Flags: review?(s.kaspari) → review+
I guess I was too late to this party.
Flags: needinfo?(bbermes)
Verified as fixed in build 48.0a2 2016-04-27;
Device: Asus ZenPad 8 (Android 5.0.2) Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.