Closed Bug 1262052 Opened 4 years ago Closed 4 years ago
Remove -mandroid default parameter from gcc
58 bytes, text/x-review-board-request
-madnroid parameter required on gcc 4.2 and 4.4 era that Android NDK had. But this option isn't required now since our requirement is gcc 4.8+. According to gcc document (https://gcc.gnu.org/onlinedocs/gcc/GNU_002fLinux-Options.html), -mandroid Compile code compatible with Android platform. This is the default on ‘*-*-linux-*android*’ targets. So, NDK sets target is *-linux-*android*, so this parameter is default, so it is unnecessary. And clang doesn't support this option. So to use clang for Android, we have to modify android.m4 to use it.
I've already did this as part of moving that to moz.configure. The patch is huge and I'm currently splitting it in small pieces for review.
When target is Android, -mandroid is default parameter from gcc 4.6 So we don't need add this options. Also clang doesn't support this argument. Review commit: https://reviewboard.mozilla.org/r/57558/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57558/
Attachment #8759595 - Flags: review?(mh+mozilla)
Comment on attachment 8759595 [details] Bug 1262052 - Remove unnecessary -mandroid parameter. https://reviewboard.mozilla.org/r/57558/#review54968 You should do the same in old-configure.in and js/src/old-configure.in.
Attachment #8759595 - Flags: review?(mh+mozilla) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/7f5be0d15ff0 Remove unnecessary -mandroid parameter. r=glandium
You need to log in before you can comment on or make changes to this bug.