Closed Bug 1262098 Opened 8 years ago Closed 8 years ago

Floating text selection: Overflow menu positioning error

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox48 verified)

VERIFIED FIXED
Firefox 48
Tracking Status
firefox48 --- verified

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(3 files)

Follow-up from bug 1171110.

It can happen that the overflow menu of a floating action mode is positioned off the screen partially (See attached screenshot).

This is actually an Android bug, filed here:
https://code.google.com/p/android/issues/detail?id=205868

Fennec is only affected if there are just two actions "Paste" (a very short one) and "Add as search engine" (a pretty long one).

This does not happen if we shorten the string to, for example, "Add search engine". However this might still be an issue in  other languages so we'd need to add a localization note explaining this.
@antlam: See screenshot and comment 0. Right now we can only fix this by using a shorter string. Are you okay with "Add search engine". Or do you have a better idea?
Flags: needinfo?(alam)
WFM!
Flags: needinfo?(alam)
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Attachment #8740920 - Flags: review?(gkruglov) → review+
Comment on attachment 8740920 [details]
MozReview Request: Bug 1262098 - Use shorter string for "Add as search engine" to avoid UI bug. r?grisha

https://reviewboard.mozilla.org/r/46081/#review43103

looks good, just curious if we can be more helpful to localizators and help avoid this bug in different locales.

::: mobile/android/locales/en-US/chrome/browser.properties:265
(Diff revision 1)
>  # the text you have selected. %S is the name of the search engine. For example, "Google".
>  contextmenu.search=%S Search
>  contextmenu.saveImage=Save Image
>  contextmenu.showImage=Show Image
>  contextmenu.setImageAs=Set Image As
> -contextmenu.addSearchEngine2=Add as Search Engine
> +# LOCALIZATION NOTE (contextmenu.addSearchEngine3): This string should be rather short or it might

Can we be more specific than "rather short"? Is there a character count we can specify here, or will it vary depending on charset/device/etc?
(In reply to :Grisha Kruglov from comment #5)
> Can we be more specific than "rather short"? Is there a character count we
> can specify here, or will it vary depending on charset/device/etc?

This is very hard to do because it varies with screen size and translation. My main goal is to make the translator aware of this issue and link to this bug - at the end of the day this needs to be tested manually. But nevertheless I'll try to describe the issue better in the comment.
https://hg.mozilla.org/integration/fx-team/rev/4646acc6df79b29e504d0fe43fef4e014b9164cb
Bug 1262098 - Use shorter string for "Add as search engine" to avoid UI bug. r=grisha
https://hg.mozilla.org/mozilla-central/rev/4646acc6df79
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
It's good practice to design the UI with +30/35% characters in mind, i.e. if en-US has 100 characters, design with space available for at least 130-135 characters (+30/35% it's the average increase in characters, with a lot of languages going well over that).

The current space is likely not enough to give an understandable translation for several languages, so the comment alone is not going to work, we should try to find a fix in the layout itself, especially considering we're blocked by a bug we don't control.
+30%/35% characters (or even more) are totally fine. This bug is triggered by a very small floating toolbar on the left side of the screen (e.g. only "Paste" available in a collapsed selection) and a larger item that is forced into the overflow menu because the screen is too small to add it to the toolbar directly (in this case: "Add as search engine". The floating toolbar will only ever expand to the left and not re-position itself if the overflow menu is larger than the toolbar (that's the bug here).

We don't have any control over the layout. We only hand the list of actions and the rect of the selection to the system. I can only see us trying to tinker with the selection rect. to avoid positioning the toolbar to far too the left in specific scenarios. But this is not really nice.

Given that all system widgets use this floating toolbar I'm surprised that there are not more apps/languages with issues.
See Also: → 1277468
Verified as fixed in 48.0a2 (2016-06-01);
Device: Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.