Closed Bug 1262105 Opened 8 years ago Closed 8 years ago

Add link to SUMO article to content notifications preference

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(1 file)

Comment on attachment 8740405 [details]
MozReview Request: Bug 1262105 - Add link to SUMO article to content notifications preference. r?grisha

https://reviewboard.mozilla.org/r/45749/#review43105

lgtm

::: mobile/android/base/resources/xml/preferences_notifications.xml:11
(Diff revision 1)
>          android:defaultValue="true" />
> +    <org.mozilla.gecko.preferences.AlignRightLinkPreference
> +        android:key="android.not_a_preference.notifications.content.learn_more"
> +        android:title="@string/pref_learn_more"
> +        android:persistent="false"
> +        url="https://support.mozilla.org/kb/notifications-firefox-android?utm_source=inproduct&amp;utm_medium=notifications&amp;utm_campaign=mobileandroid" />

I suppose content at the url will get populated eventually?

"This article doesn't have approved content yet."
Attachment #8740405 - Flags: review?(gkruglov) → review+
(In reply to :Grisha Kruglov from comment #3)
> I suppose content at the url will get populated eventually?
> 
> "This article doesn't have approved content yet."

Yeah, that's bug 1257502.
https://hg.mozilla.org/integration/fx-team/rev/53c4ca2e1c43607bcce08089eaf60b4dd43b0235
Bug 1262105 - Add link to SUMO article to content notifications preference. r=grisha
https://hg.mozilla.org/mozilla-central/rev/53c4ca2e1c43
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.