Closed Bug 1262164 Opened 5 years ago Closed 4 years ago

Stop running jemalloc configure

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox48 affected)

RESOLVED WONTFIX
Tracking Status
firefox48 --- affected

People

(Reporter: ted, Unassigned)

References

(Blocks 1 open bug)

Details

We don't actually use jemalloc's build system, but we do run its configure. We should stop doing that.

This might be fixed for free if we switched to jemalloc4?
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #0)
> We don't actually use jemalloc's build system, but we do run its configure.
> We should stop doing that.
> 
> This might be fixed for free if we switched to jemalloc4?

It's jemalloc4's configure we run.
Chris: we talked about this at the build meeting Thursday.
As an experiment I re-wrote some of the shell scripts jemalloc's configure uses to generate headers (jemalloc_rename.sh, jemalloc_mangle.sh et. al.) in Python, and found it reduces a significant portion of the overhead due to running this on Windows.

glandium, is moving these scripts to Python something likely to be accepted in upstream jemalloc? If so, where does their development take place? It looks like we don't maintain local patches to jemalloc in general.
Flags: needinfo?(mh+mozilla)
(In reply to Chris Manchester (:chmanchester) from comment #3)
> As an experiment I re-wrote some of the shell scripts jemalloc's configure
> uses to generate headers (jemalloc_rename.sh, jemalloc_mangle.sh et. al.) in
> Python, and found it reduces a significant portion of the overhead due to
> running this on Windows.
> 
> glandium, is moving these scripts to Python something likely to be accepted
> in upstream jemalloc?

I don't know, but there's no script other than shell (except autoconf stuff), so that might be a tough sale. Especially considering that adds a build dependency. Best would be to open an issue upstream and discuss the options there.

https://github.com/jemalloc/jemalloc/
Flags: needinfo?(mh+mozilla)
No longer blocks: 1129924
We'll make this block bug 1247781 instead, since this is entirely a configure-time operation.
Blocks: pyconfigure
We stopped running this with bug 1363992
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.