1262202 - perfherder compare auto select revision fails with long (40 char) revision

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

using a 12 char revision works great for auto detecting the previous revision, but the "compare to a different revision" link from a treeherder job now uses the 40 character revision.

We should support the 40 character revision inside of perfherder.

Comment 1

[William Lachance (:wlach)]

I'm not sure if I understand. What functionality specifically is not working as you expect it to?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

well when you click compare from an existing job:
https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=mozilla-central&newRevision=b6ea6a3bb8a6fc355b46403919d8c70e798c7007

there is no option to compare against the base revision, but if you shorten the revision in the url:
https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=mozilla-central&newRevision=b6ea6a3bb8a6

you will see the option to set the base revision.

Comment 3

[William Lachance (:wlach)]

Ok, gotcha! That should not be too difficult to fix, hopefully.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

in addition when viewing a graph on compare view and it highlights two points, those have 40 characters and don't highlight at all

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1262202 > mozilla:master

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8738814 [details] [review]
[treeherder] wlach:1262202 > mozilla:master

I believe this fixes the revision issues in both the compare and graphs views. It's a little bit difficult to validate this PR in the case of graphs because of bug 1255797, but I have a fix for that forthcoming as well. :)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8738814 [details] [review]
[treeherder] wlach:1262202 > mozilla:master

this looks great- a lot of things to consider!

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla/treeherder/commit/b570cd2f5650afc7dfa14e21ebb7532bb561cbbb

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8bdbbe4c257531b3ebc7cadf1352572ffb8249ce
Bug 1262202 - More fixes related to revision length for perfherder

There was a bunch of code in the compare chooser which still assumed
12 character revisions everywhere which needed to be updated.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

this doesn't seem to work:
https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=mozilla-aurora&newRevision=c1342bdc08a949c74278e59958dbecbc6f138258

I run into this at least once a week, it should be a simple fix.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

this bug would be nice to get fixed sometime soon- I heard about it from a developer in hawaii and have struggled with it myself while playing with perf alerts.

Comment 12

[William Lachance (:wlach)]

needinfo'ing myself to look into this when I'm back from pto

Comment 13

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1262202-2 > mozilla:master

Comment 14

[William Lachance (:wlach)]

Comment on attachment 8820000 [details] [review]
[treeherder] wlach:1262202-2 > mozilla:master

Ok, I think it should actually be working now.

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8820000 [details] [review]
[treeherder] wlach:1262202-2 > mozilla:master

this is much nicer

Comment 16

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0bb3d96db44d09aa8221b0c953d0b648abe992dc
Bug 1262202 - Really fix automatically getting base revision in comparechooser (#2033)

We will now automatically try or offer (as appropriate) to fetch a base
revision if the length of the revision to be compared is greater than 12.