Closed Bug 1262208 Opened 4 years ago Closed 4 years ago
Warning about disabled asm
.js is too Firefox-specific
58 bytes, text/x-review-board-request
Makes sense. What would be a good message, here? "Disabled by the current configuration"? "Disabled by the current configuration options"? Would there be an #ifdef that we could use, to indicate whether we're embedding for Firefox or not? In this case, we could keep the current message for Firefox (which is nicely descriptive, as it tells where to look at to re-enable asm.js), and put a placeholder for other embedders.
We could mention "asm.js option" or something. Maybe we can use the new system that's being added to link to wiki pages for certain errors/warnings. That wiki page could then explain where to find the Firefox pref etc.
These days, the pref is only disabled if the user did so explicitly, which means they already found it, or we're in some other embedding which might have a totally different way to toggle the option, so "disabled by 'asmjs' runtime option" seems sufficient.
Review commit: https://reviewboard.mozilla.org/r/45007/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45007/
Attachment #8738985 - Flags: review?(luke)
Comment on attachment 8738985 [details] MozReview Request: Bug 1262208: Generalize the disabled compilation mode message for asm.js; r?luke https://reviewboard.mozilla.org/r/45007/#review41525
Attachment #8738985 - Flags: review?(luke) → review+
You need to log in before you can comment on or make changes to this bug.