1262208 - Warning about disabled asm.js is too Firefox-specific

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Till Schneidereit [:till]]

If the embedding doesn't enable asm.js via the RuntimeOptions, the warning "Disabled by javascript.options.asmjs in about:config" is logged. This is problematic for Servo, which uses a different configuration system.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Makes sense. What would be a good message, here? "Disabled by the current configuration"? "Disabled by the current configuration options"?

Would there be an #ifdef that we could use, to indicate whether we're embedding for Firefox or not? In this case, we could keep the current message for Firefox (which is nicely descriptive, as it tells where to look at to re-enable asm.js), and put a placeholder for other embedders.

Comment 2

[Jan de Mooij [:jandem]]

We could mention "asm.js option" or something. Maybe we can use the new system that's being added to link to wiki pages for certain errors/warnings. That wiki page could then explain where to find the Firefox pref etc.

Comment 3

[Luke Wagner [:luke]]

These days, the pref is only disabled if the user did so explicitly, which means they already found it, or we're in some other embedding which might have a totally different way to toggle the option, so "disabled by 'asmjs' runtime option" seems sufficient.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: MozReview Request: Bug 1262208: Generalize the disabled compilation mode message for asm.js; r?luke

Review commit: https://reviewboard.mozilla.org/r/45007/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45007/

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8738985 [details]
MozReview Request: Bug 1262208: Generalize the disabled compilation mode message for asm.js; r?luke

https://reviewboard.mozilla.org/r/45007/#review41525

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d300e4102b65

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9f03bb708ec

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d300e4102b65
https://hg.mozilla.org/mozilla-central/rev/b9f03bb708ec