Closed Bug 1262225 Opened 4 years ago Closed 4 years ago

Add actorID to worker fake parent ThreadActor

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(1 file, 1 obsolete file)

We're seeing onPacket exceptions related to worker notifications not including a `from` packet field. 

> onPacket threw an exception: {"type":"newSource","source":{"actor":"server1.conn1.content-process8/worker4/4","generatedUrl":null,"url":"http://localhost:8080/worker/push-service-workers/push-service-worker.js","isB
Assignee: nobody → jlaster
Attached patch actor-id.patch (obsolete) — Splinter Review
Attachment #8738223 - Flags: review?(ejpbruel)
Comment on attachment 8738223 [details] [diff] [review]
actor-id.patch

Review of attachment 8738223 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comment addressed.

::: devtools/server/worker.js
@@ +48,5 @@
>        connection : connection,
>        rpcs: []
>      };
>  
> +    let actorID = packet.id;

This seems redundant. Why not assign packet.id to actorID directly below?
Attachment #8738223 - Flags: review?(ejpbruel) → review+
Priority: -- → P3
> Why not assign packet.id to actorID directly below

good call
Attached patch actor-id.2.patchSplinter Review
Attachment #8738223 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e6846e575ba6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.