Closed
Bug 1262233
Opened 8 years ago
Closed 8 years ago
stop using sync messages for Embedded child methods
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(5 files)
1.59 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
4.52 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
4.42 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
4.57 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
908 bytes,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
It turns out using EmbeddedObjCollector for proxies isn't trivial because of the mInt.mIndexOfEmbeddedChild stuff, but we can still share the is embedded object check with Accessible stuff.
Attachment #8738237 -
Flags: review?(lorien)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8738238 -
Flags: review?(lorien)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8738239 -
Flags: review?(lorien)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8738240 -
Flags: review?(lorien)
Updated•8 years ago
|
Attachment #8738237 -
Flags: review?(lorien) → review+
Comment 5•8 years ago
|
||
Unless I'm missing something, it doesn't seem too hard to make EmbeddedObjCollector work here. mIndexOfEmbeddedChild seems to be fairly straightforward to add to proxies, in Accessibles it seems to be only changed on shutdown (in UnbindFromParent), MoveChild, and the EmbeddedObjCollector stuff.
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Lorien Hu (:lsocks) from comment #5) > Unless I'm missing something, it doesn't seem too hard to make > EmbeddedObjCollector work here. mIndexOfEmbeddedChild seems to be fairly > straightforward to add to proxies, in Accessibles it seems to be only > changed on shutdown (in UnbindFromParent), MoveChild, and the > EmbeddedObjCollector stuff. yeah, it might not be that hard, but I'm not really convinced EmbeddedObjCollector is all that great of an idea. afaik performance of EmbeddedChildAt() and EmbeddedChildCount() is fine as is, and I expect these patches will make them faster in all but really crazy cases, so it seems like EmbeddedObjCollector may just be a waste of memory.
Updated•8 years ago
|
Attachment #8738238 -
Flags: review?(lorien) → review+
Updated•8 years ago
|
Attachment #8738239 -
Flags: review?(lorien) → review+
Updated•8 years ago
|
Attachment #8738240 -
Flags: review?(lorien) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Attachment #8740495 -
Flags: review?(lorien)
Updated•8 years ago
|
Attachment #8740495 -
Flags: review?(lorien) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6987bce671f5 https://hg.mozilla.org/integration/mozilla-inbound/rev/0efc1ab6080b https://hg.mozilla.org/integration/mozilla-inbound/rev/546156845ae5 https://hg.mozilla.org/integration/mozilla-inbound/rev/02cbaad80b65
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6987bce671f5 https://hg.mozilla.org/mozilla-central/rev/0efc1ab6080b https://hg.mozilla.org/mozilla-central/rev/546156845ae5 https://hg.mozilla.org/mozilla-central/rev/02cbaad80b65
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•