Closed Bug 1262233 Opened 8 years ago Closed 8 years ago

stop using sync messages for Embedded child methods

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(5 files)

      No description provided.
It turns out using EmbeddedObjCollector for proxies isn't trivial because of the mInt.mIndexOfEmbeddedChild stuff, but we can still share the is embedded object check with Accessible stuff.
Attachment #8738237 - Flags: review?(lorien)
Attachment #8738237 - Flags: review?(lorien) → review+
Unless I'm missing something, it doesn't seem too hard to make EmbeddedObjCollector work here. mIndexOfEmbeddedChild seems to be fairly straightforward to add to proxies, in Accessibles it seems to be only changed on shutdown (in UnbindFromParent), MoveChild, and the EmbeddedObjCollector stuff.
(In reply to Lorien Hu (:lsocks) from comment #5)
> Unless I'm missing something, it doesn't seem too hard to make
> EmbeddedObjCollector work here. mIndexOfEmbeddedChild seems to be fairly
> straightforward to add to proxies, in Accessibles it seems to be only
> changed on shutdown (in UnbindFromParent), MoveChild, and the
> EmbeddedObjCollector stuff.

yeah, it might not be that hard, but I'm not really convinced EmbeddedObjCollector is all that great of an idea.  afaik performance of EmbeddedChildAt() and EmbeddedChildCount() is fine as is, and I expect these patches will make them faster in all but really crazy cases, so it seems like EmbeddedObjCollector may just be a waste of memory.
Attachment #8738238 - Flags: review?(lorien) → review+
Attachment #8738239 - Flags: review?(lorien) → review+
Attachment #8738240 - Flags: review?(lorien) → review+
Attachment #8740495 - Flags: review?(lorien) → review+
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.