1262269 - re-enable some imagelib tests that are passing

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Seem to be passing at least on linux64 without intermittents
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3baf0bafa445&group_state=expanded

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 3

[Timothy Nikkel (:tnikkel)]

These will need to be converted to regular mochitests (bug 1262269 for my reference has plenty of examples of how to do that), but one step at a time, I'll do that in another bug.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> (bug 1262269 for my reference 

I think you meant bug 1261158 :)

Comment 5

[Timothy Nikkel (:tnikkel)]

Oddly, the other tests fail on mac and windows consistently:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e90881ca6c8&group_state=expanded

Comment 6

[Timothy Nikkel (:tnikkel)]

(In reply to Timothy Nikkel (:tnikkel) from comment #5)
> Oddly, the other tests fail on mac and windows consistently:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=4e90881ca6c8&group_state=expanded

Those failed because a support file they needed wasn't in the chrome.ini manifest (having been moved to mochitest.ini by bug 1261158 after the last _enabled_ test using them was moved over).

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98aa2df1a69f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for frequent Linux failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fb84e1e90f5

https://treeherder.mozilla.org/logviewer.html#?job_id=25490198&repo=mozilla-inbound

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Was failing on OSX 10.6 as well.

Comment 10

[Timothy Nikkel (:tnikkel)]

That's because I forgot to restore animated-gif.gif to the list of support files like comment 6 says, ugh, silly me.

Comment 11

[Timothy Nikkel (:tnikkel)]

try server run showing success on mac/windows with the fix from comment 6:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=965fcee2237975818269c1c2fef98004a553625d

comment 1 has linux try server. (the reason it failed on linux on inbound is because animated-gif.gif was removed from the test manifest a after the try run of comment 1).

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1934c6a7bbf

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1934c6a7bbf

Comment 14

[Timothy Nikkel (:tnikkel)]

Uplifted to aurora because I'm told e10s test fixes should be uplifted to aurora (these tests get converted to mochitest-plain in bug 1263474 for e10s reasons, which I also uplifted)
https://hg.mozilla.org/releases/mozilla-aurora/rev/4fcb50c0a4df11e45aef58bf0787a0889dc8b5be