Closed Bug 1262269 Opened 4 years ago Closed 4 years ago

re-enable some imagelib tests that are passing

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

No description provided.
Seem to be passing at least on linux64 without intermittents
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3baf0bafa445&group_state=expanded
Attached patch patchSplinter Review
These will need to be converted to regular mochitests (bug 1262269 for my reference has plenty of examples of how to do that), but one step at a time, I'll do that in another bug.
(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> (bug 1262269 for my reference 

I think you meant bug 1261158 :)
Oddly, the other tests fail on mac and windows consistently:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e90881ca6c8&group_state=expanded
(In reply to Timothy Nikkel (:tnikkel) from comment #5)
> Oddly, the other tests fail on mac and windows consistently:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=4e90881ca6c8&group_state=expanded

Those failed because a support file they needed wasn't in the chrome.ini manifest (having been moved to mochitest.ini by bug 1261158 after the last _enabled_ test using them was moved over).
Blocks: 1263474
Was failing on OSX 10.6 as well.
That's because I forgot to restore animated-gif.gif to the list of support files like comment 6 says, ugh, silly me.
try server run showing success on mac/windows with the fix from comment 6:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=965fcee2237975818269c1c2fef98004a553625d

comment 1 has linux try server. (the reason it failed on linux on inbound is because animated-gif.gif was removed from the test manifest a after the try run of comment 1).
https://hg.mozilla.org/mozilla-central/rev/e1934c6a7bbf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Uplifted to aurora because I'm told e10s test fixes should be uplifted to aurora (these tests get converted to mochitest-plain in bug 1263474 for e10s reasons, which I also uplifted)
https://hg.mozilla.org/releases/mozilla-aurora/rev/4fcb50c0a4df11e45aef58bf0787a0889dc8b5be
You need to log in before you can comment on or make changes to this bug.