Closed
Bug 1262269
Opened 7 years ago
Closed 7 years ago
re-enable some imagelib tests that are passing
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
1.44 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
Seem to be passing at least on linux64 without intermittents https://treeherder.mozilla.org/#/jobs?repo=try&revision=3baf0bafa445&group_state=expanded
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
These will need to be converted to regular mochitests (bug 1262269 for my reference has plenty of examples of how to do that), but one step at a time, I'll do that in another bug.
Comment 4•7 years ago
|
||
(In reply to Timothy Nikkel (:tnikkel) from comment #3) > (bug 1262269 for my reference I think you meant bug 1261158 :)
Assignee | ||
Comment 5•7 years ago
|
||
Oddly, the other tests fail on mac and windows consistently: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e90881ca6c8&group_state=expanded
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Timothy Nikkel (:tnikkel) from comment #5) > Oddly, the other tests fail on mac and windows consistently: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=4e90881ca6c8&group_state=expanded Those failed because a support file they needed wasn't in the chrome.ini manifest (having been moved to mochitest.ini by bug 1261158 after the last _enabled_ test using them was moved over).
Comment 8•7 years ago
|
||
Backed out for frequent Linux failures. https://hg.mozilla.org/integration/mozilla-inbound/rev/6fb84e1e90f5 https://treeherder.mozilla.org/logviewer.html#?job_id=25490198&repo=mozilla-inbound
Comment 9•7 years ago
|
||
Was failing on OSX 10.6 as well.
Assignee | ||
Comment 10•7 years ago
|
||
That's because I forgot to restore animated-gif.gif to the list of support files like comment 6 says, ugh, silly me.
Assignee | ||
Comment 11•7 years ago
|
||
try server run showing success on mac/windows with the fix from comment 6: https://treeherder.mozilla.org/#/jobs?repo=try&revision=965fcee2237975818269c1c2fef98004a553625d comment 1 has linux try server. (the reason it failed on linux on inbound is because animated-gif.gif was removed from the test manifest a after the try run of comment 1).
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e1934c6a7bbf
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 14•7 years ago
|
||
Uplifted to aurora because I'm told e10s test fixes should be uplifted to aurora (these tests get converted to mochitest-plain in bug 1263474 for e10s reasons, which I also uplifted) https://hg.mozilla.org/releases/mozilla-aurora/rev/4fcb50c0a4df11e45aef58bf0787a0889dc8b5be
Assignee | ||
Updated•7 years ago
|
status-firefox47:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•