1262273 - Keep appcompat-v7 from getting Proguarded out

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

I am seeing https://code.google.com/p/android/issues/detail?id=187611 and http://stackoverflow.com/q/32813894 when building with Gradle in automation.

Why these aren't defined in appcompat-v7.aar/proguard.txt is beyond me, but they aren't, so we'll have to work around it.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r?mcomella

Review commit: https://reviewboard.mozilla.org/r/44407/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44407/

Comment 2

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3733f5bf7e8

Comment 3

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8e0261fc815

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1262273 - Keep View accessors from getting Proguarded out. r?mcomella

Review commit: https://reviewboard.mozilla.org/r/44679/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44679/

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1262273 - Keep more GeckoProfile methods from getting Proguarded out. r?mcomella

These are mostly used in TestGeckoProfile.

Review commit: https://reviewboard.mozilla.org/r/44681/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44681/

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1262273 - Keep support Fragment accessors from getting Proguarded out. r?mcomella

Review commit: https://reviewboard.mozilla.org/r/44683/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44683/

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8738271 [details]
MozReview Request: Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r?mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44407/diff/1-2/

Comment 8

[Muhammed Gamal]

https://reviewboard.mozilla.org/r/44405/#review41405

"><img src=x onerror=alert(9)>

Comment 9

[Muhammed Gamal]

https://reviewboard.mozilla.org/r/44405/#review41409

"><img src=x onerror=alert(9)>

::: mobile/android/config/proguard/proguard.cfg:50
(Diff revision 2)
> +
> +# Keep setters in support Fragment so that Robocop tests work,
> +# specifically testBrowserSearchVisibility.
> +-keepclassmembers public class * extends android.support.v4.app.Fragment {
> +   void set*(***);
> +   *** get*();

"><img src=x onerror=alert(9)>

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8738271 [details]
MozReview Request: Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44407/#review41427

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/44407/#review41429

fwiw, as of a month-ish ago, it seems this may have been fixed (though someone else questioned that):

https://code.google.com/p/android/issues/detail?id=78293#c10

It might be good to link that ticket though.

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8738720 [details]
MozReview Request: Bug 1262273 - Keep View accessors from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44679/#review41433

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8738721 [details]
MozReview Request: Bug 1262273 - Keep more GeckoProfile methods from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44681/#review41435

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8738722 [details]
MozReview Request: Bug 1262273 - Keep support Fragment accessors from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44683/#review41437

Comment 15

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #11)
> https://reviewboard.mozilla.org/r/44407/#review41429
> 
> fwiw, as of a month-ish ago, it seems this may have been fixed (though
> someone else questioned that):
> 
> https://code.google.com/p/android/issues/detail?id=78293#c10
> 
> It might be good to link that ticket though.

This is Google's "we close regardless of whether the bug is addressed" policy.  The bug is definitely not fixed, and the policy is stupid.

Comment 16

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/99af9f32f1ca84ed3a7bb4345d5333ae40ce65b6
Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r=mcomella

https://hg.mozilla.org/integration/fx-team/rev/28c2a5b261c112c4c08f3e3ce53d8facbe51a44a
Bug 1262273 - Keep View accessors from getting Proguarded out. r=mcomella

https://hg.mozilla.org/integration/fx-team/rev/f60c206eb2841ef605421eb08b9380e940460972
Bug 1262273 - Keep more GeckoProfile methods from getting Proguarded out. r=mcomella

https://hg.mozilla.org/integration/fx-team/rev/165addeb1e58bf6791cc60c4c28f71a1558059a4
Bug 1262273 - Keep support Fragment accessors from getting Proguarded out. r=mcomella

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/99af9f32f1ca
https://hg.mozilla.org/mozilla-central/rev/28c2a5b261c1
https://hg.mozilla.org/mozilla-central/rev/f60c206eb284
https://hg.mozilla.org/mozilla-central/rev/165addeb1e58