Closed Bug 1262273 Opened 6 years ago Closed 6 years ago

Keep appcompat-v7 from getting Proguarded out

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(4 files)

I am seeing https://code.google.com/p/android/issues/detail?id=187611 and http://stackoverflow.com/q/32813894 when building with Gradle in automation.

Why these aren't defined in appcompat-v7.aar/proguard.txt is beyond me, but they aren't, so we'll have to work around it.
Comment on attachment 8738271 [details]
MozReview Request: Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r?mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44407/diff/1-2/
Comment on attachment 8738271 [details]
MozReview Request: Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44407/#review41427
Attachment #8738271 - Flags: review?(michael.l.comella) → review+
https://reviewboard.mozilla.org/r/44407/#review41429

fwiw, as of a month-ish ago, it seems this may have been fixed (though someone else questioned that):

https://code.google.com/p/android/issues/detail?id=78293#c10

It might be good to link that ticket though.
Comment on attachment 8738720 [details]
MozReview Request: Bug 1262273 - Keep View accessors from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44679/#review41433
Attachment #8738720 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8738721 [details]
MozReview Request: Bug 1262273 - Keep more GeckoProfile methods from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44681/#review41435
Attachment #8738721 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8738722 [details]
MozReview Request: Bug 1262273 - Keep support Fragment accessors from getting Proguarded out. r?mcomella

https://reviewboard.mozilla.org/r/44683/#review41437
Attachment #8738722 - Flags: review?(michael.l.comella) → review+
(In reply to Michael Comella (:mcomella) from comment #11)
> https://reviewboard.mozilla.org/r/44407/#review41429
> 
> fwiw, as of a month-ish ago, it seems this may have been fixed (though
> someone else questioned that):
> 
> https://code.google.com/p/android/issues/detail?id=78293#c10
> 
> It might be good to link that ticket though.

This is Google's "we close regardless of whether the bug is addressed" policy.  The bug is definitely not fixed, and the policy is stupid.
https://hg.mozilla.org/integration/fx-team/rev/99af9f32f1ca84ed3a7bb4345d5333ae40ce65b6
Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r=mcomella

https://hg.mozilla.org/integration/fx-team/rev/28c2a5b261c112c4c08f3e3ce53d8facbe51a44a
Bug 1262273 - Keep View accessors from getting Proguarded out. r=mcomella

https://hg.mozilla.org/integration/fx-team/rev/f60c206eb2841ef605421eb08b9380e940460972
Bug 1262273 - Keep more GeckoProfile methods from getting Proguarded out. r=mcomella

https://hg.mozilla.org/integration/fx-team/rev/165addeb1e58bf6791cc60c4c28f71a1558059a4
Bug 1262273 - Keep support Fragment accessors from getting Proguarded out. r=mcomella
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 48 → mozilla48
You need to log in before you can comment on or make changes to this bug.