1262278 - Rename PlanarYCbCrImage::SetData and PlanarYCbCrImage::SetDataNoCopy

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Functions that copy should have copy in the name.
My proposal is:
SetData -> CopyData
SetDataNoCopy -> AdoptData/UpdateData

However, I think it's possible that these could be improved further.

Comment 1

[Nicolas Silva [:nical]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> Functions that copy should have copy in the name.
> My proposal is:
> SetData -> CopyData
> SetDataNoCopy -> AdoptData/UpdateData

Sounds good to me! I vote for Adopt rather than Update (which we use in other places to say "copy this into my buffer").

Comment 2

[Sotaro Ikeda [:sotaro]]

I agree to comment 1.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 1 - Rename PlanarYCbCrImage::SetDataNoCopy to AdoptData

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Rename PlanarYCbCrImage::SetData to CopyData

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Thanks for writing these Sotaro.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49d1b18f1970

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49d1b18f1970