Closed Bug 1262278 Opened 4 years ago Closed 4 years ago

Rename PlanarYCbCrImage::SetData and PlanarYCbCrImage::SetDataNoCopy

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jrmuizel, Assigned: sotaro)

Details

Attachments

(2 files)

Functions that copy should have copy in the name.
My proposal is:
SetData -> CopyData
SetDataNoCopy -> AdoptData/UpdateData

However, I think it's possible that these could be improved further.
(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> Functions that copy should have copy in the name.
> My proposal is:
> SetData -> CopyData
> SetDataNoCopy -> AdoptData/UpdateData

Sounds good to me! I vote for Adopt rather than Update (which we use in other places to say "copy this into my buffer").
I agree to comment 1.
Assignee: nobody → sotaro.ikeda.g
Attachment #8742217 - Attachment description: patch - Rename PlanarYCbCrImage::SetDataNoCopy to AdoptData → patch part 1 - Rename PlanarYCbCrImage::SetDataNoCopy to AdoptData
Attachment #8742217 - Flags: review?(nical.bugzilla)
Attachment #8742218 - Flags: review?(nical.bugzilla)
Thanks for writing these Sotaro.
Attachment #8742217 - Flags: review?(nical.bugzilla) → review+
Attachment #8742218 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/49d1b18f1970
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.