Closed
Bug 1262278
Opened 8 years ago
Closed 8 years ago
Rename PlanarYCbCrImage::SetData and PlanarYCbCrImage::SetDataNoCopy
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: sotaro)
Details
Attachments
(2 files)
13.55 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
12.42 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
Functions that copy should have copy in the name. My proposal is: SetData -> CopyData SetDataNoCopy -> AdoptData/UpdateData However, I think it's possible that these could be improved further.
Comment 1•8 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #0) > Functions that copy should have copy in the name. > My proposal is: > SetData -> CopyData > SetDataNoCopy -> AdoptData/UpdateData Sounds good to me! I vote for Adopt rather than Update (which we use in other places to say "copy this into my buffer").
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8742217 -
Attachment description: patch - Rename PlanarYCbCrImage::SetDataNoCopy to AdoptData → patch part 1 - Rename PlanarYCbCrImage::SetDataNoCopy to AdoptData
Assignee | ||
Updated•8 years ago
|
Attachment #8742217 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•8 years ago
|
Attachment #8742218 -
Flags: review?(nical.bugzilla)
Reporter | ||
Comment 5•8 years ago
|
||
Thanks for writing these Sotaro.
Updated•8 years ago
|
Attachment #8742217 -
Flags: review?(nical.bugzilla) → review+
Updated•8 years ago
|
Attachment #8742218 -
Flags: review?(nical.bugzilla) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49d1b18f1970
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•