Closed Bug 1262348 Opened 4 years ago Closed 4 years ago

crashes in ss2osd.dll

Categories

(Core :: Audio/Video, defect, critical)

Unspecified
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- affected
firefox47 + wontfix
firefox48 --- fixed
firefox49 --- affected
firefox-esr45 --- affected

People

(Reporter: njn, Assigned: jrmuizel)

Details

(Keywords: crash, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-73492e10-5e14-43c9-b53e-b2aa62160330.
=============================================================

194 startup crashes with this signature in Nightly, all under gfxWindowsPlatform::InitializeDevices(). Started happening on March 19 (Nightly 20160319030558).

If you remove the address from the crash signature you get another 300+ crashes. Those ones almost all have the same crash address (0x1240) but some of them occur in older versions, mostly 45.0.1.
Milan, any idea what to do with this one?
Flags: needinfo?(milan)
It feels remarkably similar to this - https://steamcommunity.com/app/262060/discussions/3/492379159714705337/?  Sonic Studio 2 related, but I'm not sure how to proceed if this is the correct information and who to tell about it :)  :dees, any ideas?
Flags: needinfo?(milan) → needinfo?(dchinniah)
Whiteboard: [gfx-noted]
No idea here either — and I don't know anyone at Sonic Studio (hadn't even heard of it until now). I can try to locate someone there if that's the ask?
Flags: needinfo?(dchinniah)
Maybe Martin knows, especially since it seems to be coming from steam.
Flags: needinfo?(mbest)
This is still showing up highly. Nightly 20160408030212 has 102 crashes with the ss2osd.dll@0x663e signature, which is a very high number for a single Nightly build.
Crash Signature: [@ ss2osd.dll@0x556e] → [@ ss2osd.dll@0x556e] [@ ss2osd.dll@0x663e]
Crash Signature: [@ ss2osd.dll@0x556e] [@ ss2osd.dll@0x663e] → [@ ss2osd.dll@0x556e] [@ ss2osd.dll@0x663e] [@ ss2osd.dll@0x6699] [@ ss2osd.dll@0x58f9] [@ ss2osd.dll@0x4f69] [@ ss2osd.dll@0x564e] [@ ss2osd.dll@0x5d22]
Summary: crash in ss2osd.dll@0x556e → crashes in ss2osd.dll
Maybe A/V team knows what Sonic Studio is and what to do about it.
Component: Graphics → Audio/Video
Flags: needinfo?(jmuizelaar)
It seems like we should just block this dll from being in our process.
(In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> It seems like we should just block this dll from being in our process.

Who can do that? Is there a way to get a crash reports stat on how many crashes we have that are not in this DLL, but that otherwise contain this DLL?
Flags: needinfo?(anthony.s.hughes)
(In reply to Milan Sreckovic [:milan] from comment #8)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #7)
> > It seems like we should just block this dll from being in our process.
> 
> Who can do that? Is there a way to get a crash reports stat on how many
> crashes we have that are not in this DLL, but that otherwise contain this
> DLL?

No, it is not possible to search crash-stats to that level of detail as far as I know. We'd have to go through crash reports by hand to see which ones meet that criteria. 

Here is the average daily stats for the last week:
Firefox 45.0.1 is seeing ~20 crashes on 19 unique installations per day on average.
Firefox 48.0a1 is seeing ~32 crashes on 3 unique installations per day on average.

Frankly just blocking that DLL sounds like the right move as you're not talking about a lot of users and those who would be affected can't be much worse off than they already are with a startup crash. In my opinion you should also reach out to the Sonic Studio developers.
Flags: needinfo?(anthony.s.hughes)
I'll try to connect with the right folks at Sonic Studio. If I do I will add some of you folks here onto the thread.
Attached patch Block ss2osd.dllSplinter Review
Something like this should do the trick
Flags: needinfo?(jmuizelaar)
Attachment #8740612 - Flags: review?(benjamin)
Attachment #8740612 - Flags: review?(benjamin) → review+
(In reply to Desigan Chinniah [:cyberdees] [:dees] [London - GMT] from comment #10)
> I'll try to connect with the right folks at Sonic Studio. If I do I will add
> some of you folks here onto the thread.

Excellent, thanks!
Flags: needinfo?(mbest)
https://hg.mozilla.org/mozilla-central/rev/8e3a8e0f5a49
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Crash Signature: [@ ss2osd.dll@0x556e] [@ ss2osd.dll@0x663e] [@ ss2osd.dll@0x6699] [@ ss2osd.dll@0x58f9] [@ ss2osd.dll@0x4f69] [@ ss2osd.dll@0x564e] [@ ss2osd.dll@0x5d22] → [@ ss2osd.dll@0x556e] [@ ss2osd.dll@0x663e] [@ ss2osd.dll@0x6699] [@ ss2osd.dll@0x58f9] [@ ss2osd.dll@0x4f69] [@ ss2osd.dll@0x564e] [@ ss2osd.dll@0x5d22] [@ ss2osd.dll@0x5b89] [@ ss2osd.dll@0x5d82] [@ ss2osd.dll@0x4c29]
(In reply to Marco Castelluccio [:marco] from comment #15)
> Affects Firefox 46 and Firefox 47 as well:
> https://crash-stats.mozilla.com/search/?product=Firefox&signature=~ss2osd.
> dll&_facets=signature&_facets=version&_columns=date&_columns=signature&_colum
> ns=product&_columns=version&_columns=build_id&_columns=platform#facet-version

We have the fix on 48, which will be Beta in a couple of days.  With 47 about to release, Ritu, perhaps it's worth keeping this in mind as a ride along patch, in case we have a 47.0.1.  Not sure if the numbers warrant it, we can track how the 47 goes.
Assignee: nobody → jmuizelaar
Flags: needinfo?(rkothari)
(In reply to Milan Sreckovic [:milan] from comment #16)
> 
> We have the fix on 48, which will be Beta in a couple of days.  With 47
> about to release, Ritu, perhaps it's worth keeping this in mind as a ride
> along patch, in case we have a 47.0.1.  Not sure if the numbers warrant it,
> we can track how the 47 goes.

Sounds good. I've added it to the list of potential ride-alongs to consider when the time cones. Thanks for letting me know.
Flags: needinfo?(rkothari)
(In reply to Ritu Kothari (:ritu) from comment #17)
> (In reply to Milan Sreckovic [:milan] from comment #16)
> > 
> > We have the fix on 48, which will be Beta in a couple of days.  With 47
> > about to release, Ritu, perhaps it's worth keeping this in mind as a ride
> > along patch, in case we have a 47.0.1.  Not sure if the numbers warrant it,
> > we can track how the 47 goes.
> 
Hi Milan, I just reviewed the top crashers on Fx47 and I don't see a crash signature for ss2osd*.dll. Based on that, I am leaning towards wontfix'ing this for 47. Please let me know if there are any concerns.
Flags: needinfo?(milan)
All good, thanks.
Flags: needinfo?(milan)
All plugin/Flash, right?  I don't know if our DLL blocking works for plugins/Flash.
(In reply to Milan Sreckovic [:milan] from comment #21)
> All plugin/Flash, right?  I don't know if our DLL blocking works for
> plugins/Flash.

Yes, looks like they're all in Flash. I don't know that either, I'd guess it doesn't.
Aaron, can you help us clarify?  Should the DLL blocking work for Flash?
Flags: needinfo?(aklotz)
It is supposed to work in plugin-container (notwithstanding bug 1285356, which has temporarily busted things). If it's in the flash protected mode child processes, well, they're on their own.
Flags: needinfo?(aklotz)
OK, so let's wait for bug 1285356 to be fixed and then we'll check again.
Crash volume for signature 'ss2osd.dll@0x5b89':
 - nightly (version 50): 0 crash from 2016-06-06.
 - aurora  (version 49): 37 crashes from 2016-06-07.
 - beta    (version 48): 20 crashes from 2016-06-06.
 - release (version 47): 167 crashes from 2016-05-31.
 - esr     (version 45): 0 crash from 2016-04-07.

Crash volume on the last weeks:
             Week N-1   Week N-2   Week N-3   Week N-4   Week N-5   Week N-6   Week N-7
 - nightly          0          0          0          0          0          0          0
 - aurora           2         19          0          2          4         10          0
 - beta             7          5          3          1          2          1          1
 - release         32         34         18         19         23         21          7
 - esr              0          0          0          0          0          0          0

Affected platform: Windows
Crash volume for signature 'ss2osd.dll@0x4f69':
 - nightly (version 50): 0 crash from 2016-06-06.
 - aurora  (version 49): 1 crash from 2016-06-07.
 - beta    (version 48): 9 crashes from 2016-06-06.
 - release (version 47): 101 crashes from 2016-05-31.
 - esr     (version 45): 1 crash from 2016-04-07.

Crash volume on the last weeks:
             Week N-1   Week N-2   Week N-3   Week N-4   Week N-5   Week N-6   Week N-7
 - nightly          0          0          0          0          0          0          0
 - aurora           0          1          0          0          0          0          0
 - beta             2          1          0          1          2          1          0
 - release         14         14         15         10         16         15         12
 - esr              0          0          0          0          0          0          0

Affected platform: Windows
You need to log in before you can comment on or make changes to this bug.