1262365 - "Bookmark" button is not greyed out in Reader View

Status: RESOLVED DUPLICATE of bug 1234331

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2016-04-06 11:07:02.png

Tested using:
Device: Nexus 7 (Android 5.1.1)

Steps to reproduce:
1. Go to news.google.com and choose an article
2. Enter reader view
3. Open Menu

Expected results:
- "Bookmark" button should be greyed out.

Actual results:
- "Bookmark" button is not greyed out.
- Tapping it does nothing

Comment 1

[:Margaret Leibovic]

This should be fixed by bug 1234331, which has not landed yet.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1262365 - Call [NSTextInputContext handleEvent] for mouse support on IME. r?masayuki

Some IME handles mouse event by handleEvent method of NSTextInputcontext.  So we should call it on mouse event for IME

Review commit: https://reviewboard.mozilla.org/r/49209/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49209/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Makoto Kato [:m_kato] from comment #2)
> Created attachment 8745977 [details]
> MozReview Request: Bug 1262365 - Call [NSTextInputContext handleEvent] for
> mouse support on IME. r?masayuki
> 
> Some IME handles mouse event by handleEvent method of NSTextInputcontext. 
> So we should call it on mouse event for IME
> 
> Review commit: https://reviewboard.mozilla.org/r/49209/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/49209/

Hey, don't you post this patch into wrong bug?

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8745977 [details]
MozReview Request: Bug 1262365 - Call [NSTextInputContext handleEvent] for mouse support on IME. r?masayuki

sorry for mistake.