Closed Bug 1262385 Opened 4 years ago Closed 4 years ago

icudata_gas.S: Assembler messages: icudata_gas.S:6: Error: junk at end of line, first unrecognized character is `,'

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gwagner, Assigned: tzimmermann)

References

Details

Attachments

(1 file)

on b2g when building for a device:

config/external/icu/data/icudata_gas.S: Assembler messages:
config/external/icu/data/icudata_gas.S:6: Error: junk at end of line, first unrecognized character is `,'
make[6]: *** [icudata_gas.o] Error 1
make[5]: *** [config/external/icu/data/target] Error 2
make[5]: *** Waiting for unfinished jobs....
Blocks: 1239083, 1245091
Ted, this is fallout from bug 1239083. I have no idea why the syntax is different than explained in the manual. But I tested this fix and compared to the previous builds.
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Attachment #8738519 - Flags: review?(ted)
Comment on attachment 8738519 [details] [diff] [review]
[01] Bug 1262385: Fix %progbits for GAS' .section directive in ICU

Review of attachment 8738519 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I think I cargo culted this from somewhere and maybe I didn't test building it after I added it. (This code doesn't get used for desktop Firefox platforms, where we have YASM, and Android doesn't build ICU by default.)
Attachment #8738519 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/efaed594f0fd
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.