OOM could cause a crash due to bad assertion

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Unassigned)

Tracking

(Blocks 1 bug)

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

(crash signature)

Attachments

(1 attachment)

Reporter

Description

3 years ago
Noticed this crash, while checking on the MSE crash rate.

https://crash-stats.mozilla.com/report/index/09c2334d-87ae-46bb-8b7a-ddc6f2160403

This happens because of   MOZ_DIAGNOSTIC_ASSERT(mSourceBufferAttributes);
and mSourceBufferAttributes

The only way this can happen if we OOM during the appendBuffer as mSourceBufferAttributes hasn't been created yet.
Reporter

Updated

3 years ago
Blocks: 1259274
Attachment #8738499 - Flags: review?(gsquelart) → review+
Comment on attachment 8738499 [details]
MozReview Request: Bug 1262396: [MSE] Remove incorrect assertion. r?gerald

https://reviewboard.mozilla.org/r/44561/#review41259

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a2fbcf1728ca
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.