Closed Bug 1262396 Opened 4 years ago Closed 4 years ago

OOM could cause a crash due to bad assertion

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jya, Unassigned)

References

(Blocks 1 open bug)

Details

Crash Data

Attachments

(1 file)

Noticed this crash, while checking on the MSE crash rate.

https://crash-stats.mozilla.com/report/index/09c2334d-87ae-46bb-8b7a-ddc6f2160403

This happens because of   MOZ_DIAGNOSTIC_ASSERT(mSourceBufferAttributes);
and mSourceBufferAttributes

The only way this can happen if we OOM during the appendBuffer as mSourceBufferAttributes hasn't been created yet.
Blocks: 1259274
Attachment #8738499 - Flags: review?(gsquelart) → review+
Comment on attachment 8738499 [details]
MozReview Request: Bug 1262396: [MSE] Remove incorrect assertion. r?gerald

https://reviewboard.mozilla.org/r/44561/#review41259
https://hg.mozilla.org/mozilla-central/rev/a2fbcf1728ca
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.