Closed
Bug 1262399
Opened 8 years ago
Closed 8 years ago
remove Impl suffixes from nsSupports* implementations
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
34.16 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Having the Impl suffix isn't really necessary, and if we start creating instances of these classes directly, it's also rather ugly. Let's get rid of them.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8738505 -
Flags: review?(continuation)
Comment 2•8 years ago
|
||
Comment on attachment 8738505 [details] [diff] [review] remove Impl suffixes from nsSupports* implementations Review of attachment 8738505 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/ds/nsStringEnumerator.cpp @@ +122,1 @@ > if (!stringImpl) { Redundant OOM checks here and below, if you want to remove that.
Attachment #8738505 -
Flags: review?(continuation) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ceb2fd9beec7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•