If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

remove Impl suffixes from nsSupports* implementations

RESOLVED FIXED in Firefox 49

Status

()

Core
XPCOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Having the Impl suffix isn't really necessary, and if we start creating
instances of these classes directly, it's also rather ugly.  Let's get
rid of them.
(Assignee)

Comment 1

2 years ago
Created attachment 8738505 [details] [diff] [review]
remove Impl suffixes from nsSupports* implementations
Attachment #8738505 - Flags: review?(continuation)
Comment on attachment 8738505 [details] [diff] [review]
remove Impl suffixes from nsSupports* implementations

Review of attachment 8738505 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/ds/nsStringEnumerator.cpp
@@ +122,1 @@
>      if (!stringImpl) {

Redundant OOM checks here and below, if you want to remove that.
Attachment #8738505 - Flags: review?(continuation) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ceb2fd9beec7

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ceb2fd9beec7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.