Closed Bug 1262434 Opened 5 years ago Closed 5 years ago

[promise-dbg] Remove empty boilerplate file promisedebugger.properties

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: Pike, Assigned: dalimil)

References

Details

Attachments

(1 file, 1 obsolete file)

https://dxr.mozilla.org/mozilla-central/source/devtools/client/locales/en-US/promisedebugger.properties has been empty for half a year now, I think it's time to remove it.
Priority: -- → P3
I've removed the unnecessary file. There's also promisedebugger.dtd but I left it there for now.
Assignee: nobody → dalimilhajek
Status: NEW → ASSIGNED
Attachment #8790110 - Flags: review?(l10n)
Attachment #8790110 - Flags: review?(l10n) → review+
Keywords: checkin-needed
I (In reply to Dalimil Hajek [:dalimil] from comment #1)
> Created attachment 8790110 [details] [diff] [review]
> Bug1262434.patch - rev 1
> 
> I've removed the unnecessary file. There's also promisedebugger.dtd but I
> left it there for now.

promisedebugger.dtd would be safe to be removed as well.
Keywords: checkin-needed
Attached patch Bug1262434.patch - rev 2 (obsolete) — Splinter Review
I updated the patch after it has been suggested that promisedebugger.dtd should be removed too.
Attachment #8790346 - Flags: review?(l10n)
Comment on attachment 8790346 [details] [diff] [review]
Bug1262434.patch - rev 2

Review of attachment 8790346 [details] [diff] [review]:
-----------------------------------------------------------------

The title entity is used in https://dxr.mozilla.org/mozilla-central/source/devtools/client/promisedebugger/promise-debugger.xhtml#13, so this can't go away.

r-.
Attachment #8790346 - Flags: review?(l10n) → review-
Attachment #8790346 - Attachment is obsolete: true
OK, let's just go forward with the original patch.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/8267ed3c552a
[promise-dbg] Remove empty boilerplate file promisedebugger.properties. r=Pike
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8267ed3c552a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.