"Welcome to ..." gets displayed twice on standalone if there is a room name

RESOLVED FIXED

Status

P1
normal
Rank:
2
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: dcritchley)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [btpp-fix-now][47], URL)

Attachments

(7 attachments, 3 obsolete attachments)

(Reporter)

Description

2 years ago
Created attachment 8738549 [details]
Screen Shot 2016-04-06 at 15.16.44.png

See the attachment - if the room has a name, then we get "Welcome to..." displayed twice.

I think we originally did the "Welcome to Firefox Hello" as a fallback option. However, now we have the improved central information screen, and the different location for the Firefox Hello logo at top-left, it seems that the additional welcome is unnecessary, even in the case where we might not have a valid room name nor context.

Can we just drop the first line for "Welcome to Firefox Hello", and display the context tile and/or room name if they are valid?
Flags: needinfo?(sfranks)
Flags: needinfo?(b.pmm)
(Reporter)

Updated

2 years ago
Rank: 2
We definitely shouldn't be displaying two.

The original intention: It says "Welcome to Firefox Hello" if there is no edited room name. If there is a room name, then it says "Welcome to [Room Name]"
Flags: needinfo?(sfranks)
Flags: needinfo?(b.pmm)

Comment 2

2 years ago
That's exactly what Sevaan says.

Comment 3

2 years ago
Don't you guys think it would look better without "Welcome to Firefox Hello" when there is a tile (99.99% of scenarios - i.e when a user does not want to talk about an about: page)?
It says "Firefox Hello" at the center and at the top left already - that string is really useful?
My personal opinion is that it does not add value and will look better without but it's only my personal feeling!
It's not meant to be fixed there. It's just the top of the chat area, like the first item in the history, welcoming you to the room. It scrolls up and off. You don't need to see it every time.
(Assignee)

Updated

2 years ago
Assignee: nobody → dcritchley
Created attachment 8739587 [details] [review]
[loop] daveccrit:1262441-WelcomeToTwice > mozilla:master
(Assignee)

Comment 6

2 years ago
Created attachment 8739589 [details]
Screenshot with Room Name Welcome Message
(Assignee)

Comment 7

2 years ago
Created attachment 8739590 [details]
Screen Shot with No Room Name
(Assignee)

Comment 8

2 years ago
Created attachment 8739591 [details]
Screen Shot with No Context, displays Welcome to Hello
(Assignee)

Updated

2 years ago
Attachment #8739587 - Flags: review?(standard8)
Attachment #8739587 - Flags: review?(dmose)
(Reporter)

Comment 9

2 years ago
Comment on attachment 8739587 [details] [review]
[loop] daveccrit:1262441-WelcomeToTwice > mozilla:master

As commented in the PR, I think we need a slightly different approach here.
Attachment #8739587 - Flags: review?(standard8)
Attachment #8739587 - Flags: review?(dmose)
(Assignee)

Comment 10

2 years ago
As discussed, proposing alternative fix for this bug:
1) Submit string change for "Welcome to <RoomName>" to be "You have joined <RoomName>", which will take about a week to go through.
2) Disable the "Welcome to Firefox Hello" message until the string change has gone through.

If there are any changes you would like, please let me know. If not, I will proceed with this change.
Flags: needinfo?(sfranks)
(Assignee)

Updated

2 years ago
Attachment #8739587 - Flags: review?(standard8)
+1
Flags: needinfo?(sfranks)
(Reporter)

Updated

2 years ago
Attachment #8739587 - Flags: review?(standard8) → review+
(Assignee)

Comment 12

2 years ago
Temp removal of Welcome to Firefox Hello message: https://github.com/mozilla/loop/commit/5bab5525716b81dd24491e542fc881169c173fcc
(Reporter)

Updated

2 years ago
Whiteboard: [btpp-fix-now][47]
Created attachment 8742546 [details] [review]
[loop] daveccrit:1262441-ChangeStrings > mozilla:master
(Assignee)

Updated

2 years ago
Attachment #8742546 - Flags: review?(standard8)
Attachment #8742546 - Flags: review?(crafuse)
Attachment #8742546 - Flags: review?(b.mcb)
Attachment #8742546 - Flags: review?(standard8)
Attachment #8742546 - Flags: review?(crafuse)
Attachment #8742546 - Flags: review?(b.mcb)
Attachment #8742546 - Flags: review-
Created attachment 8742715 [details]
Screen Shot 2016-04-19 at 11.09.24.png

I can see both messages again. Please fix it
Comment on attachment 8742546 [details] [review]
[loop] daveccrit:1262441-ChangeStrings > mozilla:master

My fault. The patch works as expected.

Sorry Dave
Attachment #8742546 - Flags: review- → review+
(Reporter)

Updated

2 years ago
Blocks: 1265865
(Reporter)

Comment 16

2 years ago
Dave, I'd advise getting UX review on this - the spacing between the two titles seems a little wrong to me.
(Reporter)

Updated

2 years ago
Flags: needinfo?(dcritchley)

Comment 17

2 years ago
Regarding the last screen shot uploaded by Manu, when, how and who has decided to add another string reading "You have joined Mozilla" in bold?

Do we really need it? Is it useful for the user? Has it to be in bold for some reason? What's the point in keeping both strings?
Flags: needinfo?(rtestard)
(Reporter)

Comment 18

2 years ago
As per irc, see comment 10 & 12. Moving NI to Sevaan as he has been discussing this.
Flags: needinfo?(sfranks)
Maybe I misunderstood, but I thought the "Welcome to..." was being replaced by "You have joined..." which reads better than welcoming someone each time they join. There is only ever supposed to be one string displayed, and it shouldn't be bold.
Flags: needinfo?(sfranks)
(Assignee)

Comment 20

2 years ago
As per discussion with Sevaan, will be removing first message "Welcome to Firefox Hello" completely, and will be modifying the second message to always be added to chat list and it will become the only welcome message. This will also address the spacing issue.
Flags: needinfo?(rtestard)
Flags: needinfo?(dcritchley)
(Assignee)

Comment 21

2 years ago
Created attachment 8746212 [details]
Screen Shot with No Context, displays Welcome to Hello
Attachment #8739591 - Attachment is obsolete: true
(Assignee)

Comment 22

2 years ago
Created attachment 8746214 [details]
Screenshot with Room Name Welcome Message
Attachment #8739589 - Attachment is obsolete: true
(Assignee)

Comment 23

2 years ago
Created attachment 8746215 [details]
Screen Shot with No Room Name
Attachment #8739590 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8746212 - Flags: ui-review?(sfranks)
(Assignee)

Updated

2 years ago
Attachment #8746214 - Flags: ui-review?(sfranks)
(Assignee)

Updated

2 years ago
Attachment #8746215 - Flags: ui-review?(sfranks)
(Assignee)

Comment 24

2 years ago
Comment on attachment 8742546 [details] [review]
[loop] daveccrit:1262441-ChangeStrings > mozilla:master

Need a re-review, made significant changes to functionality.
Attachment #8742546 - Flags: review+ → review?(b.mcb)
(Assignee)

Updated

2 years ago
Attachment #8742546 - Flags: review?(standard8)
(Reporter)

Updated

2 years ago
Attachment #8742546 - Flags: review?(standard8)
Attachment #8742546 - Flags: review?(b.mcb)
Attachment #8746215 - Flags: ui-review?(sfranks) → ui-review+
Attachment #8746214 - Flags: ui-review?(sfranks) → ui-review+
Attachment #8746212 - Flags: ui-review?(sfranks) → ui-review+
(Assignee)

Updated

2 years ago
Attachment #8742546 - Flags: review?(standard8)
Attachment #8742546 - Flags: review?(edilee)
Attachment #8742546 - Flags: review?(dmose)
(Reporter)

Comment 25

2 years ago
Comment on attachment 8742546 [details] [review]
[loop] daveccrit:1262441-ChangeStrings > mozilla:master

Looks good. r=Standard8
Attachment #8742546 - Flags: review?(standard8)
Attachment #8742546 - Flags: review?(edilee)
Attachment #8742546 - Flags: review?(dmose)
Attachment #8742546 - Flags: review+
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Updated

2 years ago
Blocks: 1273671
You need to log in before you can comment on or make changes to this bug.