1262441 - "Welcome to ..." gets displayed twice on standalone if there is a room name

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Attachment: Screen Shot 2016-04-06 at 15.16.44.png

See the attachment - if the room has a name, then we get "Welcome to..." displayed twice.

I think we originally did the "Welcome to Firefox Hello" as a fallback option. However, now we have the improved central information screen, and the different location for the Firefox Hello logo at top-left, it seems that the additional welcome is unnecessary, even in the case where we might not have a valid room name nor context.

Can we just drop the first line for "Welcome to Firefox Hello", and display the context tile and/or room name if they are valid?

Comment 1

[Sevaan Franks [:sevaan]]

We definitely shouldn't be displaying two.

The original intention: It says "Welcome to Firefox Hello" if there is no edited room name. If there is a room name, then it says "Welcome to [Room Name]"

Comment 2

[Pau Masiá [:Pau]]

That's exactly what Sevaan says.

Comment 3

[Romain Testard [:RT]]

Don't you guys think it would look better without "Welcome to Firefox Hello" when there is a tile (99.99% of scenarios - i.e when a user does not want to talk about an about: page)?
It says "Firefox Hello" at the center and at the top left already - that string is really useful?
My personal opinion is that it does not add value and will look better without but it's only my personal feeling!

Comment 4

[Sevaan Franks [:sevaan]]

It's not meant to be fixed there. It's just the top of the chat area, like the first item in the history, welcoming you to the room. It scrolls up and off. You don't need to see it every time.

Comment 5

[GitHub Autolander Bot]

Attachment: [loop] daveccrit:1262441-WelcomeToTwice > mozilla:master

Comment 6

[David Critchley (:dcritch)]

Attachment: Screenshot with Room Name Welcome Message

Comment 7

[David Critchley (:dcritch)]

Attachment: Screen Shot with No Room Name

Comment 8

[David Critchley (:dcritch)]

Attachment: Screen Shot with No Context, displays Welcome to Hello

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8739587 [details] [review]
[loop] daveccrit:1262441-WelcomeToTwice > mozilla:master

As commented in the PR, I think we need a slightly different approach here.

Comment 10

[David Critchley (:dcritch)]

As discussed, proposing alternative fix for this bug:
1) Submit string change for "Welcome to <RoomName>" to be "You have joined <RoomName>", which will take about a week to go through.
2) Disable the "Welcome to Firefox Hello" message until the string change has gone through.

If there are any changes you would like, please let me know. If not, I will proceed with this change.

Comment 11

[Sevaan Franks [:sevaan]]

+1

Comment 12

[David Critchley (:dcritch)]

Temp removal of Welcome to Firefox Hello message: https://github.com/mozilla/loop/commit/5bab5525716b81dd24491e542fc881169c173fcc

Comment 13

[GitHub Autolander Bot]

Attachment: [loop] daveccrit:1262441-ChangeStrings > mozilla:master

Comment 14

[Manuel Casas Barrado [:mancas]]

Attachment: Screen Shot 2016-04-19 at 11.09.24.png

I can see both messages again. Please fix it

Comment 15

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8742546 [details] [review]
[loop] daveccrit:1262441-ChangeStrings > mozilla:master

My fault. The patch works as expected.

Sorry Dave

Comment 16

[Mark Banner (:standard8)]

Dave, I'd advise getting UX review on this - the spacing between the two titles seems a little wrong to me.

Comment 17

[Pau Masiá [:Pau]]

Regarding the last screen shot uploaded by Manu, when, how and who has decided to add another string reading "You have joined Mozilla" in bold?

Do we really need it? Is it useful for the user? Has it to be in bold for some reason? What's the point in keeping both strings?

Comment 18

[Mark Banner (:standard8)]

As per irc, see comment 10 & 12. Moving NI to Sevaan as he has been discussing this.

Comment 19

[Sevaan Franks [:sevaan]]

Maybe I misunderstood, but I thought the "Welcome to..." was being replaced by "You have joined..." which reads better than welcoming someone each time they join. There is only ever supposed to be one string displayed, and it shouldn't be bold.

Comment 20

[David Critchley (:dcritch)]

As per discussion with Sevaan, will be removing first message "Welcome to Firefox Hello" completely, and will be modifying the second message to always be added to chat list and it will become the only welcome message. This will also address the spacing issue.

Comment 21

[David Critchley (:dcritch)]

Attachment: Screen Shot with No Context, displays Welcome to Hello

Comment 22

[David Critchley (:dcritch)]

Attachment: Screenshot with Room Name Welcome Message

Comment 23

[David Critchley (:dcritch)]

Attachment: Screen Shot with No Room Name

Comment 24

[David Critchley (:dcritch)]

Comment on attachment 8742546 [details] [review]
[loop] daveccrit:1262441-ChangeStrings > mozilla:master

Need a re-review, made significant changes to functionality.

Comment 25

[Mark Banner (:standard8)]

Comment on attachment 8742546 [details] [review]
[loop] daveccrit:1262441-ChangeStrings > mozilla:master

Looks good. r=Standard8