Closed Bug 1262465 Opened 5 years ago Closed 4 years ago

ensure unprivileged users can mark a bug as security sensitive

Categories

(bugzilla.mozilla.org :: User Interface, defect, P1)

Production
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: dkl)

References

Details

Attachments

(1 file, 2 obsolete files)

ensure unprivileged users can mark a bug as security sensitive - basically implement bug 504461 in bug-modal.
Blocks: 1150541
Assignee: nobody → dylan
Priority: -- → P1
Attached file rev1 (obsolete) —
Assignee: dylan → sebastinssanty
Status: NEW → ASSIGNED
Attachment #8773956 - Flags: review?(dylan)
I haven't finished reviewing this yet, however it has lead me to believe we regressed on bug 504461.
Comment on attachment 8773956 [details] [review]
rev1

This didn't work out -- however it did uncover that one of my products had an empty string for its default group. Reloading my DB fixed this. Weird.
Attachment #8773956 - Flags: review?(dylan) → review-
Assignee: sebastinssanty → dylan
still working on this.

changes so far:

1) always display security module
2) this means the subtitle and on-show content has to either be "public" (for public bugs) or show a shorthand of
why the bug is visible (report/cc accessible). Of course if the bug is private to a group and a user is a member of that group, it displays as before.
Assignee: dylan → dkl
Attached patch 1262465_1.patch (obsolete) — Splinter Review
Attachment #8773956 - Attachment is obsolete: true
Attachment #8821613 - Flags: review?(dylan)
Comment on attachment 8821613 [details] [diff] [review]
1262465_1.patch

Review of attachment 8821613 [details] [diff] [review]:
-----------------------------------------------------------------

oops need one more change
Attachment #8821613 - Flags: review?(dylan)
Attached patch 1262465_2.patchSplinter Review
Attachment #8821613 - Attachment is obsolete: true
Attachment #8821616 - Flags: review?(dylan)
Comment on attachment 8821616 [details] [diff] [review]
1262465_2.patch

Review of attachment 8821616 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8821616 - Flags: review?(dylan) → review+
To https://github.com/mozilla-bteam/bmo.git
   cad5c15..550a798  master -> master
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.