1262465 - ensure unprivileged users can mark a bug as security sensitive

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect, P1)

Description

[:glob ✱]

ensure unprivileged users can mark a bug as security sensitive - basically implement bug 504461 in bug-modal.

Comment 1

[Sebastin Santy [:seban]]

Attachment: rev1

Comment 2

[Dylan Hardison [:dylan] (he/him)]

I haven't finished reviewing this yet, however it has lead me to believe we regressed on bug 504461.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8773956 [details] [review]
rev1

This didn't work out -- however it did uncover that one of my products had an empty string for its default group. Reloading my DB fixed this. Weird.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

still working on this.

changes so far:

1) always display security module
2) this means the subtitle and on-show content has to either be "public" (for public bugs) or show a shorthand of
why the bug is visible (report/cc accessible). Of course if the bug is private to a group and a user is a member of that group, it displays as before.

Comment 5

[David Lawrence [:dkl]]

Attachment: 1262465_1.patch

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 8821613 [details] [diff] [review]
1262465_1.patch

Review of attachment 8821613 [details] [diff] [review]:
-----------------------------------------------------------------

oops need one more change

Comment 7

[David Lawrence [:dkl]]

Attachment: 1262465_2.patch

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8821616 [details] [diff] [review]
1262465_2.patch

Review of attachment 8821616 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 9

[David Lawrence [:dkl]]

To https://github.com/mozilla-bteam/bmo.git
   cad5c15..550a798  master -> master