Closed Bug 1262522 Opened 4 years ago Closed 4 years ago

Land version 1.2.6 of the Loop system add-on in mozilla-central

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox46 verified, firefox47 fixed, firefox48 fixed)

RESOLVED FIXED
mozilla48
Iteration:
48.3 - Apr 25
Tracking Status
firefox46 --- verified
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

()

Details

(Whiteboard: [btpp-fix-now])

Attachments

(1 file)

Top-level changes:

- Two conversation can be opened while the new Sharing panel is shown
- Fix regression where the Turn notifications on/off button doesn't update its state
- Remove 'Beta' from Hello system add-on extension name when exported to be built into Firefox
- Localisation updates/fixes
https://hg.mozilla.org/integration/fx-team/rev/6c2da8601af9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whoops, we don't mark fixed until its landed in central ;-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/6c2da8601af9
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8738641 [details] [diff] [review]
Land version 1.2.6 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.2.x
[User impact if declined]: Contains fixes for the issues mentioned in comment 0 that were picked up by QA testing of Hello on the beta channel. Also includes the latest strings import from translated locales.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, all code changes have test coverage.
[Risks and why]: Low, minor fixes to existing code.
[String/UUID change made/needed]: None

Liz: These are small follow-ups from the issues that QA found earlier in the beta cycle. The actual code fixes are very small, but I realise its getting late in the beta cycle now.
Attachment #8738641 - Flags: approval-mozilla-beta?
Attachment #8738641 - Flags: approval-mozilla-aurora?
Comment on attachment 8738641 [details] [diff] [review]
Land version 1.2.6 of the Loop system add-on in mozilla-central. rs=Standard8 for already reviewed code.

Minor fixes for Hello/Loop. Let's uplift them to aurora and for beta 10.
Attachment #8738641 - Flags: approval-mozilla-beta?
Attachment #8738641 - Flags: approval-mozilla-beta+
Attachment #8738641 - Flags: approval-mozilla-aurora?
Attachment #8738641 - Flags: approval-mozilla-aurora+
We ran our usual regression testing using 46 beta 10 build 1 across platforms (Windows XP 64-bit, Windows 8.1 32-bit, Mac OS X 10.8 and Ubuntu 12.04 64-bit) with main focus on the changes that were added to Hello version 1.2.6 and we found two new issues but are not specific with Firefox 46. Marking as Verified Fixed.
You need to log in before you can comment on or make changes to this bug.