Closed
Bug 1262563
Opened 8 years ago
Closed 8 years ago
fire mutation events for proxied accessibles
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(7 files)
3.70 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
4.04 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
3.78 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
4.78 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
5.35 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
5.20 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
4.48 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Later we will call this for proxies where we don't have an event, and anyway all we need the event for is if it came from user input.
Attachment #8738670 -
Flags: review?(dbolter)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8738672 -
Flags: review?(dbolter)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8738673 -
Flags: review?(dbolter)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8738675 -
Flags: review?(dbolter)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8738676 -
Flags: review?(dbolter)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8738677 -
Flags: review?(dbolter)
Updated•8 years ago
|
Attachment #8738670 -
Flags: review?(dbolter) → review+
Updated•8 years ago
|
Attachment #8738672 -
Flags: review?(dbolter) → review+
Updated•8 years ago
|
Attachment #8738673 -
Flags: review?(dbolter) → review+
Updated•8 years ago
|
Attachment #8738675 -
Flags: review?(dbolter) → review+
Updated•8 years ago
|
Attachment #8738676 -
Flags: review?(dbolter) → review+
Updated•8 years ago
|
Attachment #8738677 -
Flags: review?(dbolter) → review+
Comment 7•8 years ago
|
||
Thanks for splitting this up.
Assignee | ||
Comment 8•8 years ago
|
||
Especially for hide events its better to use the parent stored in the event than the parent of the object when the event is fired. However xul trees fire show / hide events where the event's type is AccEvent not a subtype of AccMutationEvent, and in that case we need to fall back to the objects parent.
Attachment #8743487 -
Flags: review?(dbolter)
Comment 9•8 years ago
|
||
Comment on attachment 8743487 [details] [diff] [review] fix how FireShowHideEvent gets the parent of a hide event target Review of attachment 8743487 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment. Also it might be good to specify this patch is atk only in the commit message. ::: accessible/atk/AccessibleWrap.cpp @@ +1374,5 @@ > + AccMutationEvent* event = downcast_accEvent(aEvent); > + Accessible* parentAcc = event ? event->Parent() : accessible->Parent(); > + AtkObject* parent = AccessibleWrap::GetAtkObject(parentAcc); > + return FireAtkShowHideEvent(atkObj, parent, false, > + aEvent->IsFromUserInput()); Mostly cut and paste right? Slight odor... worth a function? (Might be a good place to add a comment about XUL being the reason we need to resort to accessible->Parent in the ternary)
Attachment #8743487 -
Flags: review?(dbolter) → review+
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e91f473726bc https://hg.mozilla.org/integration/mozilla-inbound/rev/78140cef0896 https://hg.mozilla.org/integration/mozilla-inbound/rev/c75cf06452fb https://hg.mozilla.org/integration/mozilla-inbound/rev/b94b668c0b94 https://hg.mozilla.org/integration/mozilla-inbound/rev/c6223b401549 https://hg.mozilla.org/integration/mozilla-inbound/rev/d70ec2a35552
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e91f473726bc https://hg.mozilla.org/mozilla-central/rev/78140cef0896 https://hg.mozilla.org/mozilla-central/rev/c75cf06452fb https://hg.mozilla.org/mozilla-central/rev/b94b668c0b94 https://hg.mozilla.org/mozilla-central/rev/c6223b401549 https://hg.mozilla.org/mozilla-central/rev/d70ec2a35552
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•