1262584 - Some [component:error] messages are not appearing as errors in Treeherder

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect)

Description

[Greg Arndt [:garndt]]

[test.sh:error] is not getting parsed from the logs and displayed on treeherder when there is an error

Example: https://tools.taskcluster.net/task-inspector/#dS8qWfFiTTWKYTf5VFL5sw/0

Which is this Treeherder job:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=c111173a1b98ae219a1172cd7fb15dc8c629e2a2&selectedJob=25265477

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Is this an error in the log parser?  Is it the `.`?

Comment 2

[Greg Arndt [:garndt]]

It's the '.' because the regex was limited in what it was looking for.  I'm going to updated the regex to something like:

^\[[\w._-]+:(?:error|exception)\]

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] gregarndt:improve_error_regex > mozilla:master

Comment 4

[Greg Arndt [:garndt]]

Attachment: https://github.com/mozilla/treeherder/pull/1392

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8738739 [details] [review]
https://github.com/mozilla/treeherder/pull/1392

I'm going to steal this review and give it an r+. Seems like a no-brainer, and I'm about to deploy to stage for testing so this might as well come along for the ride.

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f12d860785e80088ca2a69cb1a62c81da1697502
Bug 1262584 - Improve taskcluster error regex

https://github.com/mozilla/treeherder/commit/eed5606fa62666ba0d551991e0e80de4fecd6574
Merge pull request #1392 from gregarndt/improve_error_regex

Bug 1262584 - Improve taskcluster error regex

Comment 8

[Ed Morley [:emorley]]

Many thanks for fixing this :-)